From: Kevin Hilman <khilman@baylibre.com>
To: Tony Lindgren <tony@atomide.com>, linux-omap@vger.kernel.org
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
devicetree@vger.kernel.org, "Benoit Parrot" <bparrot@ti.com>
Subject: Re: [PATCH] ARM: dts: dra7: Fix suspend warning for vpe powerdomain
Date: Wed, 09 Mar 2022 03:07:20 -0800 [thread overview]
Message-ID: <7h5yon9yfr.fsf@baylibre.com> (raw)
In-Reply-To: <20220308102103.39086-1-tony@atomide.com>
Tony Lindgren <tony@atomide.com> writes:
> We currently are getting the following warning after a system suspend:
>
> Powerdomain (vpe_pwrdm) didn't enter target state 0
>
> Looks like this is because the STANDBYMODE bit for SMART_IDLE should
> not be used. The TRM "Table 12-348. VPE_SYSCONFIG" says that the value
> for SMART_IDLE is "0x2: Same behavior as bit-field value of 0x1". But
> if the SMART_IDLE value is used, PM_VPE_PWRSTST LASTPOWERSTATEENTERED
> bits always show value of 3.
>
> Let's fix the issue by dropping SMART_IDLE for vpe. And let's also add
> the missing the powerdomain for vpe.
>
> Fixes: 1a2095160594 ("ARM: dts: dra7: Add ti-sysc node for VPE")
> Cc: Benoit Parrot <bparrot@ti.com>
> Reported-by: Kevin Hilman <khilman@baylibre.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Thanks for the fix. Verified on beagle-x5.
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>
prev parent reply other threads:[~2022-03-09 11:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 10:21 [PATCH] ARM: dts: dra7: Fix suspend warning for vpe powerdomain Tony Lindgren
2022-03-09 11:07 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7h5yon9yfr.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=bcousson@baylibre.com \
--cc=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).