From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2C60C433FE for ; Wed, 9 Mar 2022 11:07:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231827AbiCILIW (ORCPT ); Wed, 9 Mar 2022 06:08:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231358AbiCILIV (ORCPT ); Wed, 9 Mar 2022 06:08:21 -0500 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7776A16EAAC for ; Wed, 9 Mar 2022 03:07:22 -0800 (PST) Received: by mail-pj1-x1035.google.com with SMTP id mg21-20020a17090b371500b001bef9e4657cso4966955pjb.0 for ; Wed, 09 Mar 2022 03:07:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=GLJWgSjpL4AJbuDEGF6NGRPWdFEMcqQSg2kXliO5hus=; b=R+d/qGWeT5qXfRaxjp8CLmUjwJTwOQYZk/aL3Pudw7PNp1skPxoqIcZx8tZC/AsCBu OZkUXE3WW5HBfguS2vZNquGWQUqu15bjm/HznCdGFFQiiHyGbZK5Un2C30yuIxQtUEdj AiLO91WrQmy4dBDphQWVvBG/bG6Cc8GAACx1XVCJpgoAgS40cAae7EvLzNV+CkpG5tjE ykxC8CI53DCPmj1mzpqeUrOdLjqIay9qsDM0DKl11wfpPPhoTgXnqA/5pamPT5AJiveq FH8Q4VN71mgf5TRXSDUw03F/4dz8iLk7hqQT1D7iZ1YwIJ1+v51qgqxkk6GXUr16eLje L34A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=GLJWgSjpL4AJbuDEGF6NGRPWdFEMcqQSg2kXliO5hus=; b=8RZpBP1Mn2654GKSUd2TDk7tl+4h9hxulj/KwWYPQoZ624qJm9ozvfUe7QwB3/NJW3 gmRf9z0Kj5669YdD/Np4HhLnRbWKURj4JH041tdviDjqbny20XCtOXyWVoSz2HsjlEl5 7NFKOOAecXNAl9qmKhsFNIq42dqhDhpJk6g0+ingqgv43pZTqBDzT8vCgSBQmh6i6BYJ z3ZrcWvbamGQDTxZBWgUn42ZUzpmc1dyk9QMZpqSl09GFfDy8BXhfEdJDk4r1d/rVT68 t9OKqJdp0OryZ29Vd185TrRbCM7RZlRTfwd6XLX5UN1KEcNCcgcfT2QmonLTXEhjzj0p qLNQ== X-Gm-Message-State: AOAM530D6DP7zt0MP2VZmdsJ2hvSxbfX9x6v37b43DZc9P8NlIh4ATWb x3ZgVp4bXuNV7dS6G59XBD2evksKs9mfeT49VfI= X-Google-Smtp-Source: ABdhPJzwG3BRXkYf6NwrB7hwcCNkzwY8m//tw1wMLbbQiSMQXSj6BcATixtWdlPpj0lBrkWRiwbo2Q== X-Received: by 2002:a17:90b:4b06:b0:1bf:8e05:84a9 with SMTP id lx6-20020a17090b4b0600b001bf8e0584a9mr7496823pjb.27.1646824041650; Wed, 09 Mar 2022 03:07:21 -0800 (PST) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id d11-20020a056a0024cb00b004f725ecf900sm2627557pfv.97.2022.03.09.03.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 03:07:21 -0800 (PST) From: Kevin Hilman To: Tony Lindgren , linux-omap@vger.kernel.org Cc: =?utf-8?Q?Beno=C3=AEt?= Cousson , devicetree@vger.kernel.org, Benoit Parrot Subject: Re: [PATCH] ARM: dts: dra7: Fix suspend warning for vpe powerdomain In-Reply-To: <20220308102103.39086-1-tony@atomide.com> References: <20220308102103.39086-1-tony@atomide.com> Date: Wed, 09 Mar 2022 03:07:20 -0800 Message-ID: <7h5yon9yfr.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Tony Lindgren writes: > We currently are getting the following warning after a system suspend: > > Powerdomain (vpe_pwrdm) didn't enter target state 0 > > Looks like this is because the STANDBYMODE bit for SMART_IDLE should > not be used. The TRM "Table 12-348. VPE_SYSCONFIG" says that the value > for SMART_IDLE is "0x2: Same behavior as bit-field value of 0x1". But > if the SMART_IDLE value is used, PM_VPE_PWRSTST LASTPOWERSTATEENTERED > bits always show value of 3. > > Let's fix the issue by dropping SMART_IDLE for vpe. And let's also add > the missing the powerdomain for vpe. > > Fixes: 1a2095160594 ("ARM: dts: dra7: Add ti-sysc node for VPE") > Cc: Benoit Parrot > Reported-by: Kevin Hilman > Signed-off-by: Tony Lindgren Thanks for the fix. Verified on beagle-x5. Reviewed-by: Kevin Hilman Tested-by: Kevin Hilman