From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5042BC433FE for ; Mon, 7 Nov 2022 21:18:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233070AbiKGVS2 (ORCPT ); Mon, 7 Nov 2022 16:18:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233557AbiKGVSE (ORCPT ); Mon, 7 Nov 2022 16:18:04 -0500 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 566C7317FE for ; Mon, 7 Nov 2022 13:14:53 -0800 (PST) Received: by mail-pf1-x42a.google.com with SMTP id m6so11880529pfb.0 for ; Mon, 07 Nov 2022 13:14:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=5sT7hyCzk9AIqzLbGef+IZ6oJ71RYXWRSZsmUSzO4Yg=; b=P39f7quD853DqM9BBAZi7j1TweO0zXhBFPBLff8eSw0GyPIz2vlyw2NVWhiVuCc9on ZwVgJzNNqjm3e5FZtd6E7iux1mqK/TfXu9YuFK8up7u7ux+VO6b7VNSQk7Mxs3rH6eJN Z7Cd+eLOaD6B3EbEqKVnzXjDCYTHNRcGg43OpYLgICerBRLns7ZVbqpDb5gute1wLruH aJHq2V7yN1f0vRjwa8TwiapmnSZxbOB6B8/GOHUq+PQL/5p6MgBTnMuWz+FCYu+JieUH VbiIsg7WjXHu8Wws2UzTZvODI36Ihj6SCAykvT91K+3xGAQfxqn/5jCOFNzwwPHzMu4L goTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5sT7hyCzk9AIqzLbGef+IZ6oJ71RYXWRSZsmUSzO4Yg=; b=ffeEvf6B3TptH9I8l7q1fRiUFZVWKffbtyW/KkInZLTbxItOvqrnjYqro++EQHov4O 1ORrRvDwBKqCS7QwbcGQ/zTQTndJueQMV2muD5ozPi1lCDwji3jJC9iJf7D+FJfbTkHW 0lAZTlXloB9NW56o1miQMSYvnR8qsEqy7Zl6nyPTszBMCEhgdK4KkUCH1/Hkz7DnGM16 FQ+AaXIZoTrASKDcjyj2R9rfvl+TimrOXvQj5FDW9q+9PyuxyBfEfIN/x4nfPWLmnTx9 8muKomDBxyNiFVSExSsIN1d+lo/9mYZ+Mdap4Xi9UPDlyb1xcfsAmi58FvZeAzekPzDO RyPA== X-Gm-Message-State: ACrzQf3PU8f+PD3T343hD/MqQqudwLrsHqy9cQrCuYDq2WalAvg2XZuk +SSv0WVh/OVmBMUC7Tjq8zvtyw== X-Google-Smtp-Source: AMsMyM4fNroJ8un5Wi3EJ604VEP8sq2WlbsGxu3Ax4KtJVEcz4IY0/3AIrVFwaBzallESNsw1/AyxQ== X-Received: by 2002:a63:5811:0:b0:46f:a710:1b77 with SMTP id m17-20020a635811000000b0046fa7101b77mr39853531pgb.392.1667855692494; Mon, 07 Nov 2022 13:14:52 -0800 (PST) Received: from localhost ([75.172.139.56]) by smtp.gmail.com with ESMTPSA id a10-20020a63cd4a000000b0043941566481sm4624005pgj.39.2022.11.07.13.14.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Nov 2022 13:14:52 -0800 (PST) From: Kevin Hilman To: Nishanth Menon , jerome Neanne Cc: Lee Jones , lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, kristo@kernel.org, dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org, catalin.marinas@arm.com, will@kernel.org, tony@atomide.com, vigneshr@ti.com, bjorn.andersson@linaro.org, shawnguo@kernel.org, geert+renesas@glider.be, dmitry.baryshkov@linaro.org, marcel.ziswiler@toradex.com, vkoul@kernel.org, biju.das.jz@bp.renesas.com, arnd@arndb.de, jeff@labundy.com, afd@ti.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v6 4/6] mfd: tps65219: Add driver for TI TPS65219 PMIC In-Reply-To: <20221105000104.rtj3r6ufqwqmepon@keenly> References: <20221011140549.16761-1-jneanne@baylibre.com> <20221011140549.16761-5-jneanne@baylibre.com> <1383fd22-c720-811e-a2bb-be2151675089@baylibre.com> <20221105000104.rtj3r6ufqwqmepon@keenly> Date: Mon, 07 Nov 2022 13:14:51 -0800 Message-ID: <7heduewjp0.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Nishanth Menon writes: > On 13:58-20221104, jerome Neanne wrote: >>=20 > [...] > >>=20 >> >=20 >> > Can you try an compile with W=3D1 please. >> This raise one warning on mfd: >> drivers/mfd/tps65219.c:28:12: warning: =E2=80=98tps65219_soft_shutdown= =E2=80=99 defined but >> not used [-Wunused-function] >> 28 | static int tps65219_soft_shutdown(struct tps65219 *tps) >> | ^~~~~~~~~~~~~~~~~~~~~~ >> soft_shutdown has been validated and is used in TI baseline even if not >> hooked in upstream version further to this review: >> https://lore.kernel.org/lkml/20220825150224.826258-5-msp@baylibre.com/ >>=20 >> It was a TI requirement to implement it... >> Let me know if you want me to remove this function or if we can keep it = like >> this. > > There are platforms without psci, correct? I think the comment was to > drop the force override with system-power-controller property, > > if (!pm_power_off) { > tps65219_i2c_client =3D client; > pm_power_off =3D &tps65219_pm_power_off; > } > > Could still be valid for such platforms, no? I do see that the > capability that the PMIC has - which is software shutdown is a valid > feature that we support in many different PMIC drivers. Is'nt the job of > the driver to introduce the functionality in a manner that is > appropriate to the OS framework? Yeah, I think Nishanth is right here. We should probably keep the `if (!pm_power_off)` part so the PMIC will be used if PSCI is not, but it also allows an easy way to test/use the PMIC shutdown functionality downstream if needed. Kevin