From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC721C433FE for ; Tue, 1 Feb 2022 18:36:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241865AbiBASgO (ORCPT ); Tue, 1 Feb 2022 13:36:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233694AbiBASgN (ORCPT ); Tue, 1 Feb 2022 13:36:13 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB799C06173D for ; Tue, 1 Feb 2022 10:36:13 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id h14so16111218plf.1 for ; Tue, 01 Feb 2022 10:36:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=uymdiPAHYMV+vGLrmLiiTQE2p6SugIXA4tmHpTGQbjY=; b=qUZrCeISmIWgpM3iteLe2br7t59/dMGDq8fMoccYVxIu8FYC+5uJFIP3SGc63ezqDv 8O2Zl5OYLbH9gJgjwO3juwPtNL2X54jGdyfxsy5CzSjkxAVMiGgRzeQNF1/6S++zcRiM dwWFcxr5zlou7e4+73jqrtJq0eTIZyMOLIML+r/5dF7FWIyPW8u/fVDPsjNKLfOtfpTI G+CzAvVYQQeZSJIU3HeZ7wezHRtGing5eS1kJK5UPJJaND1+/h0oVXPiVgJ8+V5SQHn3 73Bg64yat6rN4X9QIVIxDpXZT/E6WKVGqzaLYwHslGH4dhK6BjX8D1efX/nfGy1odPTd g6Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=uymdiPAHYMV+vGLrmLiiTQE2p6SugIXA4tmHpTGQbjY=; b=kQUbiQxSe36rs4oFYzteTA1oZFdMmkSNBKmRdD2qUWqrV35XkvZkO20pLDCWhpu+uz 2gUmCavkIDT6hvaboKQuaqTPczINn6Cavkz3xVyO40HrJuORmN2NWfDfBd0eNgi5MEXU gfm2XCUBiHkbg8w6SJ5AkpYa/Zew5kD+So2lOqAG66XUaMc0Nn5NmsPjcDH5Rb9wS2QM kbcBnuQGgb92WYbkGSBTj1bL2cCJu9vFDQKy6uOMO/GEJtKkcjxzD5sQa0obDxxCHH7D R5a61B4UKe6q/snIc/V/TAylC9XHMD3D5ULFPT2NrRjzkxtAmP0QeBLKWQlFJI9ssVNZ 8YSQ== X-Gm-Message-State: AOAM531wqRiN8AUhGWMZpHNKKaMFD9pU/10eeV4bHoiEHTN8vxaVj/SV OS/bzOcg5CO7EzwLNR0Me+7txQ== X-Google-Smtp-Source: ABdhPJz+xggSIZUfFn6fGeLQIQxLGEjAl8f1fJRDpC8QIRmqiiesC6t91zcdEmPTvWWB3uCdEyYplA== X-Received: by 2002:a17:90b:1a8f:: with SMTP id ng15mr3762577pjb.235.1643740573012; Tue, 01 Feb 2022 10:36:13 -0800 (PST) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id j4sm23038417pfc.217.2022.02.01.10.36.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Feb 2022 10:36:12 -0800 (PST) From: Kevin Hilman To: Saravana Kannan Cc: Russell King , Neil Armstrong , Geert Uytterhoeven , Magnus Damm , Tony Lindgren , Catalin Marinas , Will Deacon , Damien Le Moal , Greg Kroah-Hartman , Ulf Hansson , Rob Herring , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-oxnas@groups.io, linux-renesas-soc@vger.kernel.org, linux-omap@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v4 1/2] drivers: bus: simple-pm-bus: Add support for probing simple bus only devices In-Reply-To: References: <20210929000735.585237-1-saravanak@google.com> <20210929000735.585237-2-saravanak@google.com> <7hk0efmfzo.fsf@baylibre.com> Date: Tue, 01 Feb 2022 10:36:11 -0800 Message-ID: <7hee4mmo2s.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Saravana Kannan writes: > On Mon, Jan 31, 2022 at 7:18 PM Kevin Hilman wrote: >> >> Hi Saravana, >> >> Saravana Kannan writes: >> >> > fw_devlink could end up creating device links for bus only devices. >> > However, bus only devices don't get probed and can block probe() or >> > sync_state() [1] call backs of other devices. To avoid this, probe these >> > devices using the simple-pm-bus driver. >> > >> > However, there are instances of devices that are not simple buses (they get >> > probed by their specific drivers) that also list the "simple-bus" (or other >> > bus only compatible strings) in their compatible property to automatically >> > populate their child devices. We still want these devices to get probed by >> > their specific drivers. So, we make sure this driver only probes devices >> > that are only buses. >> > >> > [1] - https://lore.kernel.org/lkml/CAPDyKFo9Bxremkb1dDrr4OcXSpE0keVze94Cm=zrkOVxHHxBmQ@mail.gmail.com/ >> > Fixes: c442a0d18744 ("driver core: Set fw_devlink to "permissive" behavior by default") >> > Signed-off-by: Saravana Kannan >> > Tested-by: Saravana Kannan >> > Tested-by: Ulf Hansson >> >> This patch landed in stable/linux-5.10.y as commit d5f13bbb5104 and it >> broke suspend/resume on at least one TI AM335x board I'm testing on: >> upstream dts: arch/arm/boot/dts/am335x-icev2.dts, upstream defconfig: >> arch/arm/configs/omap2plus_defconfig. >> >> Bisecting between vanilla v5.10 (good) and stable/linux-5.10.y (bad) >> pointed me to this patch, and I confirmed that reverting just this patch >> on top of stable/linux-5.10.y makes it work again. >> >> Also interesting, this same platform works fine on vanilla v5.15, which >> also includes this patch. That suggests that either 1) this patch >> should not have been backported to v5.10 stable or 2) there are some >> other dependencies that are missing in v5.10. >> >> Since vanilla v5.10 works fine, I'm leaning towards (1), but if you have >> any ideas for deps that need backporting, I'm happy to try. > > Oh wow! I didn't realize I made so many changes AFTER 5.10! Unless I'm > doing something wrong with my git commands. > $ git log v5.10..v5.15 --oneline -- drivers/of/property.c > $ git log v5.10..v5.15 --oneline --author=saravanak -- drivers/base/ > > If you don't think I got my git command completely wrong, yeah, way > too many patches are missing on 5.10. I'd go with the option of > dropping this patch on 5.10. I agree. Could you submit a revert for v5.10 stable? As the patch author, it's probably better if it comes from you. >> I haven't debugged exactly where it's hanging yet, but, enabling >> CONFIG_DEBUG_DRIVER=y, and suspending with "no_console_suspend" on the >> command line, the last line before it hangs is: >> >> [ 28.129966] simple-pm-bus ocp: noirq power domain suspend >> >> Any ideas? > > I'd guess it's either a sync_state() happening too soon since some of > the dependencies aren't tracked. Or some dependency cycle that'd be > handled correctly if the rest of the patches were picked up. Yeah, a > pretty broad/vague answer. Heh, yeah, and also suggests that there's other gotchas hiding in other dark corners, which also suggests that revert is the best path for v5.10. Thanks for the quick response, Kevin