From: Kevin Hilman <khilman@baylibre.com>
To: Parvathi Pudi <parvathi@couthit.com>,
aaro.koskinen@iki.fi, andreas@kemnade.info, rogerq@kernel.org,
tony@atomide.com
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
nm@ti.com, pratheesh@ti.com, prajith@ti.com, vigneshr@ti.com,
danishanwar@ti.com, praneeth@ti.com, srk@ti.com, rogerq@ti.com,
afd@ti.com, krishna@couthit.com, pmohan@couthit.com,
mohan@couthit.com, parvathi@couthit.com, basharath@couthit.com
Subject: Re: [PATCH v1 1/1] bus: ti-sysc: PRUSS OCP configuration
Date: Thu, 01 May 2025 11:07:29 -0700 [thread overview]
Message-ID: <7htt64urvi.fsf@baylibre.com> (raw)
In-Reply-To: <20250407072134.1044797-2-parvathi@couthit.com>
Parvathi Pudi <parvathi@couthit.com> writes:
> Updates OCP master port configuration to enable memory access outside
> of the PRU-ICSS subsystem.
>
> This set of changes configures PRUSS_SYSCFG.STANDBY_INIT bit to enable
> the OCP master ports during resume sequence and disables the OCP master
> ports during suspend sequence (applicable only on SoCs using OCP
> interconnect like the OMAP family).
>
> Signed-off-by: Parvathi Pudi <parvathi@couthit.com>
> ---
> drivers/bus/ti-sysc.c | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> index f67b927ae4ca..51caae611acf 100644
> --- a/drivers/bus/ti-sysc.c
> +++ b/drivers/bus/ti-sysc.c
> @@ -2036,6 +2036,19 @@ static void sysc_module_disable_quirk_pruss(struct sysc *ddata)
> sysc_write(ddata, ddata->offsets[SYSC_SYSCONFIG], reg);
> }
>
> +static void sysc_module_enable_quirk_pruss(struct sysc *ddata)
> +{
> + u32 reg;
> +
> + reg = sysc_read(ddata, ddata->offsets[SYSC_SYSCONFIG]);
> + /* Clearing the SYSC_PRUSS_STANDBY_INIT bit - Updates OCP master
> + * port configuration to enable memory access outside of the
> + * PRU-ICSS subsystem.
> + */
minor nit: incorrect multi-line comment style (first /* should be on
line of its own)
But I fixed this up locally before applying.
Kevin
next prev parent reply other threads:[~2025-05-01 18:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 7:21 [PATCH v1 0/1] Adds support for OCP master port configuration of PRU-ICSS Parvathi Pudi
2025-04-07 7:21 ` [PATCH v1 1/1] bus: ti-sysc: PRUSS OCP configuration Parvathi Pudi
2025-04-26 9:54 ` Andreas Kemnade
2025-04-29 12:04 ` Parvathi Pudi
2025-05-01 18:07 ` Kevin Hilman [this message]
2025-05-01 18:11 ` Kevin Hilman
2025-04-23 12:39 ` [PATCH v1 0/1] Adds support for OCP master port configuration of PRU-ICSS Parvathi Pudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7htt64urvi.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=aaro.koskinen@iki.fi \
--cc=afd@ti.com \
--cc=andreas@kemnade.info \
--cc=basharath@couthit.com \
--cc=danishanwar@ti.com \
--cc=krishna@couthit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mohan@couthit.com \
--cc=nm@ti.com \
--cc=parvathi@couthit.com \
--cc=pmohan@couthit.com \
--cc=prajith@ti.com \
--cc=praneeth@ti.com \
--cc=pratheesh@ti.com \
--cc=rogerq@kernel.org \
--cc=rogerq@ti.com \
--cc=srk@ti.com \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox