Re: [PATCH] FB support for OMAP2

[Romain Goyet <r.goyet@gmail.com>]

Hi Tony,
You might push this if you want, but I'm preparing a slightly bigger
patch that will include this one. (Since even with this Palm TE
support is still broken...)

Kind regards,
Romain Goyet

2005/11/29, Tony Lindgren <tony@atomide.com>:
> * Romain Goyet <r.goyet@gmail.com> [051127 23:11]:
> > .
> > After checking, it appeared your patch was just working great : my
> > Palm's in fact crashing because of a bug in the function
> > paging_init(); in arch/arm/mm/init.c.
> >
> > 2005/11/28, Imre Deak <imre.deak@nokia.com>:
> > > Hi,
> > >
> > > For me it didn't even build for PALMTE, so this is at least needed:
> > >
> > > diff --git a/drivers/video/omap/lcdc.c b/drivers/video/omap/lcdc.c
> > > index fd5e137..5700d25 100644
> > > --- a/drivers/video/omap/lcdc.c
> > > +++ b/drivers/video/omap/lcdc.c
> > > @@ -439,7 +439,7 @@ static void inline setup_regs(void)
> > >  #ifdef CONFIG_MACH_OMAP_PALMTE
> > >  /* FIXME:if (machine_is_omap_palmte()) { */
> > >                 /* PalmTE uses alternate TFT setting in 8BPP mode */
> > > -               l |= (tft && fbdev->panel->video_mode->bpp == 8) ? 0x810000 : 0;
> > > +               l |= (is_tft && panel->bpp == 8) ? 0x810000 : 0;
> > >  /*     } */
> > >  #endif
> > >         omap_writel(l, OMAP_LCDC_CONTROL);
>
> Pushing this today.
>
> Tony
>