From: Sekhar Nori <nsekhar@ti.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>,
Roger Quadros <rogerq@ti.com>,
davem@davemloft.net, tony@atomide.com
Cc: jsarha@ti.com, linux-omap@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: am335x-icev2: Add CPSW ethernet0 and ethernet1
Date: Tue, 14 Mar 2017 11:37:10 +0530 [thread overview]
Message-ID: <815d2848-86e1-7ca2-a07c-4a69816d6ab0@ti.com> (raw)
In-Reply-To: <51a2471f-dace-6d8b-b198-9bd5efe41387@ti.com>
On Tuesday 14 March 2017 12:54 AM, Grygorii Strashko wrote:
>
>
> On 03/13/2017 08:42 AM, Roger Quadros wrote:
>> Enable the 2 ethernet ports as CPSW ports in dual-mac mode
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> [nsekhar@ti.com: use AM33XX_IOPAD()]
>> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
>> ---
>> arch/arm/boot/dts/am335x-icev2.dts | 113
>> +++++++++++++++++++++++++++++++++++++
>> 1 file changed, 113 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am335x-icev2.dts
>> b/arch/arm/boot/dts/am335x-icev2.dts
>> index a2ad076..cc343b0 100644
>> --- a/arch/arm/boot/dts/am335x-icev2.dts
>> +++ b/arch/arm/boot/dts/am335x-icev2.dts
>> @@ -201,6 +201,69 @@
>> AM33XX_IOPAD(0x938, PIN_OUTPUT_PULLUP | MUX_MODE1) /*
>> (L16) gmii1_rxd2.uart3_txd */
>> >;
>> };
>> +
>
>>
>> &i2c0 {
>> @@ -350,3 +413,53 @@
>> pinctrl-0 = <&uart3_pins_default>;
>> status = "okay";
>> };
>> +
>> +&gpio3 {
>> + p4 {
>> + gpio-hog;
>> + gpios = <4 GPIO_ACTIVE_HIGH>;
>> + output-high;
>> + line-name = "PR1_MII_CTRL";
>> + };
>> +
>> + p10 {
>> + gpio-hog;
>> + gpios = <10 GPIO_ACTIVE_HIGH>;
>> + /* ETH1 mux: Low for MII-PRU, high for RMII-CPSW */
>> + output-high;
>> + line-name = "MUX_MII_CTL1";
>> + };
>> +};
>> +
>> +&cpsw_emac0 {
>> + phy_id = <&davinci_mdio>, <1>;
>
> this is deprecated definition.
> pls, use phy-handle.
Perhaps cpsw driver should warn about using deprecated DT properties.
Thanks,
Sekhar
next prev parent reply other threads:[~2017-03-14 6:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 13:42 [PATCH 0/2] ARM: am335x-icev2: Add ethernet support Roger Quadros
2017-03-13 13:42 ` [PATCH 1/2] net: davinci_mdio: add GPIO reset logic Roger Quadros
2017-03-13 13:42 ` [PATCH 2/2] ARM: dts: am335x-icev2: Add CPSW ethernet0 and ethernet1 Roger Quadros
2017-03-13 19:24 ` Grygorii Strashko
2017-03-14 6:07 ` Sekhar Nori [this message]
2017-03-14 12:50 ` [PATCH v2 " Roger Quadros
2017-03-14 12:51 ` [PATCH 3/3] ARM: omap2plus_defconfig: Enable TI Ethernet PHY Roger Quadros
2017-03-30 12:35 ` [PATCH 0/2] ARM: am335x-icev2: Add ethernet support Roger Quadros
2017-04-04 16:01 ` Tony Lindgren
2017-04-04 17:35 ` David Miller
2017-04-05 8:35 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=815d2848-86e1-7ca2-a07c-4a69816d6ab0@ti.com \
--to=nsekhar@ti.com \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=jsarha@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox