public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
To: linux-omap-open-source@linux.omap.com
Subject: [PATCH] omapfb: Add sanity check to omapfb_update_window_async
Date: Sun, 14 Jan 2007 14:38:53 +0100	[thread overview]
Message-ID: <858xg5g236.fsf@orfeo.duckcorp.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]


This patch makes sure that the fb_info pointer given to
omapfb_update_window_async is not null.

Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
---

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: omapfb_update_window_async_check.patch --]
[-- Type: text/x-diff, Size: 880 bytes --]

---
 drivers/video/omap/omapfb_main.c |    9 	7 +	2 -	0 !
 1 file changed, 7 insertions(+), 2 deletions(-)

Index: linux-omap-2.6/drivers/video/omap/omapfb_main.c
===================================================================
--- linux-omap-2.6.orig/drivers/video/omap/omapfb_main.c	2007-01-14 14:10:26.000000000 +0100
+++ linux-omap-2.6/drivers/video/omap/omapfb_main.c	2007-01-14 14:10:29.000000000 +0100
@@ -626,10 +626,15 @@ int omapfb_update_window_async(struct fb
 				void (*callback)(void *),
 				void *callback_data)
 {
-	struct omapfb_plane_struct *plane = fbi->par;
-	struct omapfb_device *fbdev = plane->fbdev;
+	struct omapfb_plane_struct *plane;
+	struct omapfb_device *fbdev;
 	struct fb_var_screeninfo *var;
 
+	if (!fbi)
+		return -EINVAL;
+
+	plane = fbi->par;
+	fbdev = plane->fbdev;
 	var = &fbi->var;
 
 	if (win->x >= var->xres || win->y >= var->yres)

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



             reply	other threads:[~2007-01-14 13:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-14 13:38 Arnaud Patard [this message]
2007-01-26 21:54 ` [PATCH] omapfb: Add sanity check to omapfb_update_window_async Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=858xg5g236.fsf@orfeo.duckcorp.org \
    --to=arnaud.patard@rtp-net.org \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox