From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
To: linux-omap-open-source@linux.omap.com
Subject: [PATCH] dsp: don't use registered_fb[1]
Date: Sun, 14 Jan 2007 14:38:50 +0100 [thread overview]
Message-ID: <85ac0lg239.fsf@orfeo.duckcorp.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 451 bytes --]
According to dsp_fbexport(), the dsp code handles only the first
registered framebuffer, so using registered_fb[1] in mbox_fbctl_upd is
wrong. registered_fb[0] must be used instead.
This code has also the side effect to oops the kernel as
registered_fb[1] is null and omapfb_update_window_async doesn't handle
this case. The fix for omapfb_update_window_async is sent in an other
mail.
Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
---
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: dsp_mem_registered_fb_fix.patch --]
[-- Type: text/x-diff, Size: 714 bytes --]
---
arch/arm/plat-omap/dsp/dsp_mem.c | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-omap-2.6/arch/arm/plat-omap/dsp/dsp_mem.c
===================================================================
--- linux-omap-2.6.orig/arch/arm/plat-omap/dsp/dsp_mem.c 2007-01-14 14:10:26.000000000 +0100
+++ linux-omap-2.6/arch/arm/plat-omap/dsp/dsp_mem.c 2007-01-14 14:10:37.000000000 +0100
@@ -2052,7 +2052,7 @@ void mbox_fbctl_upd(void)
return;
}
//printk("calling omapfb_update_window_async()\n");
- omapfb_update_window_async(registered_fb[1], &win, fbupd_cb, NULL);
+ omapfb_update_window_async(registered_fb[0], &win, fbupd_cb, NULL);
}
#else /* CONFIG_FB_OMAP_LCDC_EXTERNAL */
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
next reply other threads:[~2007-01-14 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-14 13:38 Arnaud Patard [this message]
2007-01-26 21:51 ` [PATCH] dsp: don't use registered_fb[1] Tony Lindgren
2007-01-28 5:13 ` Hiroshi DOYU
2007-01-31 18:58 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85ac0lg239.fsf@orfeo.duckcorp.org \
--to=arnaud.patard@rtp-net.org \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox