From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnaud Patard (Rtp) Subject: [PATCH] dsp: don't use registered_fb[1] Date: Sun, 14 Jan 2007 14:38:50 +0100 Message-ID: <85ac0lg239.fsf@orfeo.duckcorp.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-omap-open-source-bounces@linux.omap.com Errors-To: linux-omap-open-source-bounces@linux.omap.com To: linux-omap-open-source@linux.omap.com List-Id: linux-omap@vger.kernel.org --=-=-= According to dsp_fbexport(), the dsp code handles only the first registered framebuffer, so using registered_fb[1] in mbox_fbctl_upd is wrong. registered_fb[0] must be used instead. This code has also the side effect to oops the kernel as registered_fb[1] is null and omapfb_update_window_async doesn't handle this case. The fix for omapfb_update_window_async is sent in an other mail. Signed-off-by: Arnaud Patard --- --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=dsp_mem_registered_fb_fix.patch --- arch/arm/plat-omap/dsp/dsp_mem.c | 2 1 + 1 - 0 ! 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-omap-2.6/arch/arm/plat-omap/dsp/dsp_mem.c =================================================================== --- linux-omap-2.6.orig/arch/arm/plat-omap/dsp/dsp_mem.c 2007-01-14 14:10:26.000000000 +0100 +++ linux-omap-2.6/arch/arm/plat-omap/dsp/dsp_mem.c 2007-01-14 14:10:37.000000000 +0100 @@ -2052,7 +2052,7 @@ void mbox_fbctl_upd(void) return; } //printk("calling omapfb_update_window_async()\n"); - omapfb_update_window_async(registered_fb[1], &win, fbupd_cb, NULL); + omapfb_update_window_async(registered_fb[0], &win, fbupd_cb, NULL); } #else /* CONFIG_FB_OMAP_LCDC_EXTERNAL */ --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --=-=-=--