public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
To: Felipe Balbi <ext-felipe.lima@nokia.com>
Cc: Linux OMAP Mailing List <linux-omap-open-source@linux.omap.com>,
	linux-usb-devel@lists.sourceforge.net
Subject: Re: Invalid Storage Class BUG
Date: Wed, 01 Nov 2006 22:32:00 +0100	[thread overview]
Message-ID: <85ejsmn99r.fsf@orfeo.duckcorp.org> (raw)
In-Reply-To: <4549087F.5070701@nokia.com> (Felipe Balbi's message of "Wed, 01 Nov 2006 16:50:07 -0400")

[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]

Felipe Balbi <ext-felipe.lima@nokia.com> writes:

> Hello all,

Hi !

>
> Could anyone help me fix this bug?
>
> I couldn't figure out what is happening.
>
> Here's the bug:
> drivers/usb/core/hub.c: In function 'usb_new_device':
> drivers/usb/core/hub.c:1293: error: invalid storage class for function
> '__usb_port_suspend'
> drivers/usb/core/hub.c:1294: warning: implicit declaration of function
> '__usb_port_suspend'
> drivers/usb/core/hub.c: At top level:
> drivers/usb/core/hub.c:1567: error: static declaration of
> '__usb_port_suspend' follows non-static declaration
> drivers/usb/core/hub.c:1294: error: previous implicit declaration of
> '__usb_port_suspend' was here
> make[3]: *** [drivers/usb/core/hub.o] Error 1
> make[2]: *** [drivers/usb/core] Error 2
> make[1]: *** [drivers/usb] Error 2
> make: *** [drivers] Error 2
>

Try the attached patch. It's a quick fix/hack and has not been tested in
every configurations but it should be enough to get things working.

Regards,
Arnaud Patard



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: usb_core_hub_breakage.patch --]
[-- Type: text/x-patch, Size: 929 bytes --]

---
 drivers/usb/core/hub.c |    3 	1 +	2 -	0 !
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: linux-omap-2.6/drivers/usb/core/hub.c
===================================================================
--- linux-omap-2.6.orig/drivers/usb/core/hub.c	2006-10-24 14:06:58.000000000 +0200
+++ linux-omap-2.6/drivers/usb/core/hub.c	2006-10-24 14:07:46.000000000 +0200
@@ -1188,6 +1188,7 @@ static inline void show_string(struct us
 
 #ifdef	CONFIG_USB_OTG
 #include "otg_whitelist.h"
+static int __usb_port_suspend(struct usb_device *udev, int port1);
 #endif
 
 /**
@@ -1289,8 +1290,6 @@ int usb_new_device(struct usb_device *ud
 		 * (Includes HNP test device.)
 		 */
 		if (udev->bus->b_hnp_enable || udev->bus->is_b_host) {
-			static int __usb_port_suspend(struct usb_device *,
-						int port1);
 			err = __usb_port_suspend(udev, udev->bus->otg_port);
 			if (err < 0)
 				dev_dbg(&udev->dev, "HNP fail, %d\n", err);

[-- Attachment #3: Type: text/plain, Size: 373 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #4: Type: text/plain, Size: 191 bytes --]

_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

  parent reply	other threads:[~2006-11-01 21:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-01 20:50 Invalid Storage Class BUG Felipe Balbi
2006-11-01 21:14 ` Alan Stern
2006-11-01 21:58   ` Andrew Morton
2006-11-01 21:32 ` Arnaud Patard [this message]
2006-11-01 22:26   ` David Brownell
2006-11-01 22:41     ` Andrew Morton
2006-11-01 22:48       ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85ejsmn99r.fsf@orfeo.duckcorp.org \
    --to=arnaud.patard@rtp-net.org \
    --cc=ext-felipe.lima@nokia.com \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=linux-usb-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox