From: Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>
To: linux-omap-open-source@linux.omap.com
Subject: [PATCH] mtd/cmdlinepart.c: remove static declaration of mtdpart_setup
Date: Thu, 01 Feb 2007 11:09:58 +0100 [thread overview]
Message-ID: <85odoenq89.fsf@orfeo.duckcorp.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 470 bytes --]
Hi,
The n770 (and maybe the n800 too) are using a tag for setting the
mtd partition layout and not the command line. The commit in linus tree
ddacff1f20fc5c96cc73e2975258e05d298c97cc is setting mtdpart_setup as
static, preventing its use in the omap-hw driver and thus, is breaking
the build.
So, here's a patch to revert it. imho we'll have to carry it in the omap
tree until the omap-hw driver is merged.
Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
---
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: make_mtdpart_setup_not_static.patch --]
[-- Type: text/x-diff, Size: 1077 bytes --]
Revert the following commit :
commit ddacff1f20fc5c96cc73e2975258e05d298c97cc
Author: Adrian Bunk <bunk@stusta.de>
Date: Sat Nov 25 20:15:41 2006 +0100
[MTD] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static
This patch makes the needlessly global mtdpart_setup() static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Otherwise, the omap-hw can't work when the partition layout is in a TAG.
---
drivers/mtd/cmdlinepart.c | 2 1 + 1 - 0 !
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-omap-2.6/drivers/mtd/cmdlinepart.c
===================================================================
--- linux-omap-2.6.orig/drivers/mtd/cmdlinepart.c 2007-01-27 12:01:17.000000000 +0100
+++ linux-omap-2.6/drivers/mtd/cmdlinepart.c 2007-01-27 12:01:23.000000000 +0100
@@ -345,7 +345,7 @@ static int parse_cmdline_partitions(stru
*
* This function needs to be visible for bootloaders.
*/
-static int mtdpart_setup(char *s)
+int mtdpart_setup(char *s)
{
cmdline = s;
return 1;
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
next reply other threads:[~2007-02-01 10:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-01 10:09 Arnaud Patard [this message]
2007-02-01 18:20 ` [PATCH] mtd/cmdlinepart.c: remove static declaration of mtdpart_setup Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85odoenq89.fsf@orfeo.duckcorp.org \
--to=arnaud.patard@rtp-net.org \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox