Re: [PATCH] add ssi/Kconfig to arch/arm/Kconfig

[Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>]

Dirk Behme <dirk.behme@googlemail.com> writes:

> Arnaud Patard (Rtp) wrote:
>> If one wants to use ssi/Kconfig on arm, it should be added to
>> arch/arm/Kconfig.
>
> Yes, I found this as well by getting
>
> sound/arm/Kconfig:55:warning: 'select' used by config symbol
> 'SND_OMAP_TSC2101' refer to undefined symbol 'OMAP_TSC2101'
> sound/arm/Kconfig:56:warning: 'select' used by config symbol
> 'SND_OMAP_TSC2101' refer to undefined symbol 'OMAP_UWIRE'
>
> Kconfig warnings.

same here :)

>
> While touching this, what do you think about doing some more
> clean up:
>
> - omap_uwire.c is now in drivers/spi [], remove (old?) one from
> drivers/ssi

I had the same patch but you send it before me :)

>
> - Replace OMAP_UWIRE in Kconfig by SPI_OMAP_UWIRE pointing
> to drivers/spi
>
> ?
>

Even if I'm not a omap dev, I'll be happy to see the ssi stuff go to
/dev/null. Unfortunately, grep is telling us that there are still users
of the old omap_uwire. Moreover, it seems that it's possible to build a
kernel without the OMAP_UWIRE and with the drivers using it. The drivers
using the old ssi stuff should either depends on it or select it...
(see drivers/video/omap/lcd_{p,h}2.c).
Until this is solved, we won't be able to remove it :(


Arnaud