From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E250EC433EF for ; Thu, 5 May 2022 16:31:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232478AbiEEQfL (ORCPT ); Thu, 5 May 2022 12:35:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238980AbiEEQfK (ORCPT ); Thu, 5 May 2022 12:35:10 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5B76541A4; Thu, 5 May 2022 09:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651768290; x=1683304290; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=J1ejMXF3Bd/GCmguw/mohOzkY0z/abBYcpbEVngnjig=; b=KSBY0jJmug1QLSllDfxfXJoymE8MCbG4vSp2SNpi4ko5CBkdKaYBv8na oAXqk5im1MyZtnkOM4csj/zmr80lNEEQ7bqQmSZxkCOtyDBVO3eKHn3LC 1PPAnTDzVJDbY8uTYACwn3Q4x5uNwT0++oMXF2zrLtJJEnL3G41GXw3ZD 13Xa6qKC1hPOF4m31Wx5RFd8gArAec5xgL6KLT1dU8UbjJmkZd514vGnJ JqXWoWkKYQADCLBK5IzN4yKtrL9bwTwmvwHr6/JLbAEhvkGVeRGWYGJO+ zMb07850Elzk6kMAx94ejo55gHydwI5wSgXjFw3cZdUff86bALm41oqDH g==; X-IronPort-AV: E=McAfee;i="6400,9594,10338"; a="328713910" X-IronPort-AV: E=Sophos;i="5.91,201,1647327600"; d="scan'208";a="328713910" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 09:31:18 -0700 X-IronPort-AV: E=Sophos;i="5.91,201,1647327600"; d="scan'208";a="694739879" Received: from evegaag-mobl1.amr.corp.intel.com (HELO [10.209.187.127]) ([10.209.187.127]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2022 09:31:17 -0700 Message-ID: <8704209d-d487-a297-b05a-5db99f5f808c@intel.com> Date: Thu, 5 May 2022 09:31:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] ARM: dove: fix returnvar.cocci warnings Content-Language: en-US To: Arnd Bergmann , kernel test robot Cc: kbuild-all@lists.01.org, Linux Memory Management List , Tony Lindgren , Russell King , linux-omap , Linux ARM , Linux Kernel Mailing List References: <202205031017.4TwMan3l-lkp@intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On 5/3/22 00:21, Arnd Bergmann wrote: > On Tue, May 3, 2022 at 4:45 AM kernel test robot wrote: >> From: kernel test robot >> >> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 >> >> Remove unneeded variable used to store return value. >> >> Generated by: scripts/coccinelle/misc/returnvar.cocci >> >> Reported-by: kernel test robot >> Signed-off-by: kernel test robot > I checked the patch, and unfortunately it is wrong, the current code > needs to stay. > The problem is the SET_DMA_ERRATA() macro that accesses the > local 'errata' variable. 0day folks, do we have humans looking over these before they're going out to the list? If not, can we add some? If so, can the humans get a little more discerning? ;)