Re: [PATCH v3 13/21] ARM: omap: convert wakeupgen to stacked domains

[Marc Zyngier <marc.zyngier@arm.com>]

On Wed, Jan 14 2015 at 10:28:14 pm GMT, Tony Lindgren <tony@atomide.com> wrote:
> * Marc Zyngier <marc.zyngier@arm.com> [150112 10:30]:
>> OMAP4/5 has been (ab)using the gic_arch_extn to provide
>> wakeup from suspend, and it makes a lot of sense to convert
>> this code to use stacked domains instead.
>> 
>> This patch does just this, updating the DT files to actually
>> reflect what the HW provides.
>> 
>> BIG FAT WARNING: because the DTs were so far lying by not
>> exposing the WUGEN HW block, kernels with this patch applied
>> won't have any suspend-resume facility when booted with old DTs,
>> and old kernels with updated DTs won't even boot.
>> 
>> On a platform with this patch applied, the system looks like
>> this:
>> 
>> root@bacon-fat:~# cat /proc/interrupts
>>             CPU0       CPU1
>>  16:          0          0     WUGEN  37  gp_timer
>>  19:     233799     155916       GIC  27  arch_timer
>>  23:          0          0     WUGEN   9  l3-dbg-irq
>>  24:          1          0     WUGEN  10  l3-app-irq
>>  27:        282          0     WUGEN  13  omap-dma-engine
>>  44:          0          0  4ae10000.gpio  13  DMA
>
> FYI, the legacy irq numbers are now all wrong since commit
> 9a1091ef0017 ("irqchip: gic: Support hierarchy irq domain.").
>
> Started a separate thread "Regression with legacy IRQ numbers
> caused by 9a1091ef0017" on it, will give these a try once
> that's sorted out.

Assuming the workaround I posted earlier works, the OMAP/DRA7 part of
this series is going to require some rework too (I need to know where
these legacy interrupts are attached: crossbar, WUGEN, or GIC?).

Thanks,

        M.
-- 
Jazz is not dead. It just smells funny.