From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH-V5 2/3] arm:omap:am33xx: Add AM335XEVM machine support Date: Thu, 03 May 2012 14:17:34 -0700 Message-ID: <871un1j769.fsf@ti.com> References: <1322808204-12878-3-git-send-email-hvaibhav@ti.com> <79CD15C6BA57404B839C016229A409A83EA10A64@DBDE01.ent.ti.com> <20120503155717.GE5140@atomide.com> <79CD15C6BA57404B839C016229A409A83EA1348F@DBDE01.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog108.obsmtp.com ([74.125.149.199]:42931 "EHLO na3sys009aog108.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753382Ab2ECVRc (ORCPT ); Thu, 3 May 2012 17:17:32 -0400 Received: by dadv2 with SMTP id v2so2714550dad.4 for ; Thu, 03 May 2012 14:17:30 -0700 (PDT) In-Reply-To: <79CD15C6BA57404B839C016229A409A83EA1348F@DBDE01.ent.ti.com> (Vaibhav Hiremath's message of "Thu, 3 May 2012 16:41:44 +0000") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Hiremath, Vaibhav" Cc: Tony Lindgren , Paul Walmsley , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "Mohammed, Afzal" "Hiremath, Vaibhav" writes: > On Thu, May 03, 2012 at 21:27:18, Tony Lindgren wrote: >> Hi, >> >> * Hiremath, Vaibhav [120502 02:37]: >> > On Wed, May 02, 2012 at 14:53:24, Paul Walmsley wrote: >> > > Hi >> > > >> > > On Fri, 2 Dec 2011, hvaibhav@ti.com wrote: >> > > >> > > > From: Afzal Mohammed >> > > > >> > > > This patch adds minimal support for AM335X EVM. >> > > > The approach taken here is to add AM335X EVM support >> > > > to AM3517EVM, considering the fact that with device tree >> > > > developement we will get rid of board-*.c. >> > > > >> > > > Signed-off-by: Afzal Mohammed >> > > > Signed-off-by: Vaibhav Hiremath >> > > > Reviewed-by: Kevin Hilman >> > > >> > > I realize people may not necessarily like this, but I think that the >> > > AM33xx EVM needs its own board file. This is because it really has >> > > nothing to do with the AM3517EVM. Also, the AM3517EVM depends on >> > > CONFIG_ARCH_OMAP3, but the AM33xx EVM should not: it should depend on >> > > either CONFIG_ARCH_OMAPAM33XX, or CONFIG_ARCH_OMAP4. >> >> I guess adding CONFIG_SOC_AM33XX makes sense if it does not share anything >> except core with omap3. And the SOC is independent of the core selected, >> there is no dependency between SoC and the core. >> >> Note that we have CONFIG_ARCH_OMAP2PLUS, all the other ones should be just >> CONFIG_SOC_XXX. As all omap3 omap4 and am33xx are v7, there's no need to >> compile with different flags either. >> > > What about cpu_is_omap34xx() true for am33xx? Should we follow it? Please, no. I've already demonstrated that that is not necessary and only leads to confusion and maintenance headaches. Kevin