Re: [PATCH 08/12] arm: omap3: am35x: Fix clockdomain dependencies

Paul Walmsley
2012-04-11T23:49:35Z

On Wed, 11 Apr 2012, Mark A. Greer wrote:

> On Wed, Apr 11, 2012 at 04:04:44PM -0600, Paul Walmsley wrote:
> > On Wed, 11 Apr 2012, Mark A. Greer wrote:
> >
> > > On Wed, Apr 11, 2012 at 03:44:38PM -0600, Paul Walmsley wrote:
> > >
> > > > Looks like there are an extra set of commas here, maybe just use:
> > > >
> > > > static struct clkdm_dep gfx_sgx_am35x_wkdeps[] = {
> > > > { .clkdm_name = "mpu_clkdm" },
> > > > { .clkdm_name = "wkup_clkdm" },
> > > > { NULL },
> > >
> > > Yes, there are extra commas but they come from the code I'm copying
> > > and removing iva2_clkdm from. I was keeping things consistent so I
> > > kept the commas. Given that, do you still want them removed?
> > > (I'm indifferent.)
> >
> > Yes please. I realize it's a minor issue, but I'd like to keep the format
> > of these files internally consistent.
>
> Hrm, did you meant "No thanks"? As in, leave the commas there since
> that's what the code that is already there is like?

The current data is in this format:

/* 3430 PM_WKDEP_CAM: IVA2, MPU, WKUP */
static struct clkdm_dep cam_wkdeps[] = {
{ .clkdm_name = "iva2_clkdm" },
{ .clkdm_name = "mpu_clkdm" },
{ .clkdm_name = "wkup_clkdm" },
{ NULL },
};

So if you can match that, it would be ideal.

- Paul