Re: [PATCH 12/12] arm: omap3: am35x: Register davinci_mdio before davinci_emac

Paul Walmsley
2012-04-11T21:24:06Z

cc Ilya

On Wed, 11 Apr 2012, Mark A. Greer wrote:

> From: "Mark A. Greer" <mgreer@animalcreek.com>
>
> Problem:
> --------
> When resuming from a Suspend-to-RAM event, the eth0 device
> (davinci emac/mdio) on am35xx boards wouldn't work and the
> following error message appeared on the console:
>
> "net eth0: could not connect to phy davinci_mdio-0:00"

...

> Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>
> ---
> arch/arm/mach-omap2/am35xx-emac.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/am35xx-emac.c b/arch/arm/mach-omap2/am35xx-emac.c
> index 1f97e74..d23bd6c 100644
> --- a/arch/arm/mach-omap2/am35xx-emac.c
> +++ b/arch/arm/mach-omap2/am35xx-emac.c

This is a little off-topic from this patch, but we should get rid of this
arch/arm/mach-omap2/am35xx-emac.c file. These on-chip devices should be
registered via the hwmod code. Looking at
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c, I don't see any trace of the
EMAC or MDIO in there. That's where all of these IPSS IP blocks should be
declared...

- Paul