Re: [PATCH 1/1] OMAP: TWL: set clk32kg regulator on

[Kevin Hilman <khilman@ti.com>]

"Mahaveer, Vishal" <vishalm@ti.com> writes:

>>> omap4_clk32kg regulator is used by connectivity (WLAN/BT/GPS) chip on
>>> omap4 platforms.
>>> Set always_on flag to true for connectivity chip to operate.
>>
>> The driver/init for the connectivity chip should be using the regulator
>> API to enable/disable the regulator as needed.
>
> The connectivity chip is used for BT, WLAN, FM and GPS. So we want it
> on at all times.

No.

You want it on only

1) if the connectivity chip is present, *and*
2) BT, WLAN, FM or GPS are being used.

The current patch assumes that a connectivity chip is present whenever
the TWL is present, which may be true on the platform you're currently
working on, but is not true in general.

And, even if it were present, for power reasons the regulator should be
enabled only when it's needed, not because it might be needed.  That
means that the device-specific (or board specific) code should be
configuring the regulators used for the various modules so the drivers
can request the regulators when they're needed.

Kevin