From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [POWER DOMAIN suspend callbacks] Observation. Date: Tue, 23 Aug 2011 10:06:05 -0700 Message-ID: <871uwcjbwi.fsf@ti.com> References: <4E53B6FC.8030507@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog105.obsmtp.com ([74.125.149.75]:58276 "EHLO na3sys009aog105.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755234Ab1HWRGJ (ORCPT ); Tue, 23 Aug 2011 13:06:09 -0400 Received: by mail-gw0-f50.google.com with SMTP id 16so271807gwj.37 for ; Tue, 23 Aug 2011 10:06:08 -0700 (PDT) In-Reply-To: <4E53B6FC.8030507@ti.com> (Santosh's message of "Tue, 23 Aug 2011 19:49:40 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Santosh Cc: "Rafael J. Wysocki" , Linux PM mailing list , linux-omap@vger.kernel.org, Govindraj R Hi Santosh, Santosh writes: > Rafael, Kevin, > > On latest kernel( V3.1-rc1+), the subsystem(driver) suspend > callbacks are not getting called because power domain callbcaks > are populated. > > And as per commit 4d27e9dc{PM: Make power domain callbacks take > precedence over subsystem ones}, it's expected bahavior. Correct. > Who is suppose to call the driver suspend callback? If populated, the PM domain callbacks should call the driver callbacks. If there are no PM domain callbacks, then the subsystem (in this case, the platform_bus) should be calling the driver callbacks. > Some drivers/subsystem would have state machine which needs to > be suspended. > > Is the power domain suspend callback, suppose to take care of > it ? If yes, then that seems to be missing for OMAP. Yup, there's a bug. They're not missing, just misplaced. ;) When adding the noirq callbacks to ensure devices are idled late in suspend by omap_device, I the patch commited mistakenly uses SET_SYSTEM_SLEEP_PM_OPS(), which sets the "normal" suspend/resume handlers and not the noirq handlers. Can you try the patch below? I only briefly tested it on omap3/n900 so far. This populates most of the PM domain methods with the same ones used by the subystem (platform_bus) and only overrides the noirq methods with custom versions. This patch should make all the driver's suspend/resume methods be called as expected. After a bit more sanitiy testing, I'll post a real patch for the -rc series. Kevin diff --git a/arch/arm/plat-omap/omap_device.c b/arch/arm/plat-omap/omap_device.c index d8f2299..7a0d248 100644 --- a/arch/arm/plat-omap/omap_device.c +++ b/arch/arm/plat-omap/omap_device.c @@ -626,7 +626,8 @@ static struct dev_pm_domain omap_device_pm_domain = { SET_RUNTIME_PM_OPS(_od_runtime_suspend, _od_runtime_resume, _od_runtime_idle) USE_PLATFORM_PM_SLEEP_OPS - SET_SYSTEM_SLEEP_PM_OPS(_od_suspend_noirq, _od_resume_noirq) + .suspend_noirq = _od_suspend_noirq, + .resume_noirq = _od_resume_noirq, } };