Re: [PATCH 6/7] OMAP4: hwmod data: TEMP: Fix timer1 main_clk

[Kevin Hilman <khilman@ti.com>]

"Cousson, Benoit" <b-cousson@ti.com> writes:

> On 6/28/2011 2:19 AM, Hilman, Kevin wrote:
>> Benoit Cousson<b-cousson@ti.com>  writes:
>> 
>>> Since the timer is still not pm_runtime adapted, it is still
>>> using directly the physical clock nodes at init time.
>>>
>>> Replace the clock node by the original one in the clock data
>>> file.
>>>
>>> Keep the original name until the driver is fixed.
>> 
>> Is this still needed when used with Tony's devel-timer branch?
>
> I didn't follow what Tony did, but I'm not sure he is fixing that part.
>  
>> I assume not.
>
> After checking the new timer.c file, we still have the problematic part. Only the migration to hwmod will fix that:
>
> static int __init omap_dm_timer_init_one(struct omap_dm_timer *timer,
> 						int gptimer_id,
> 						const char *fck_source)
> {
>
> [...]
>
> 	/* After the dmtimer is using hwmod these clocks won't be needed */
> 	sprintf(name, "gpt%d_fck", gptimer_id);
> 	timer->fclk = clk_get(NULL, name);
> 	if (IS_ERR(timer->fclk))
> 		return -ENODEV;
>
> 	sprintf(name, "gpt%d_ick", gptimer_id);
> 	timer->iclk = clk_get(NULL, name);
> 	if (IS_ERR(timer->iclk)) {
> 		clk_put(timer->fclk);
> 		return -ENODEV;
> 	}
>
> There is even a comment that confirm the issue:-)

Well, I'm not sure that comment is correct either.

Tony's series converts the driver to use hwmod.  The problem is the
clocks are still needed for changing the parent, so there is still
a clk_disable, clk_set_parent, clk_enable sequence used.

Kevin