* [PATCH 2/9 v3] usb: musb: Remove board_data parameter from musb_platform_init()
@ 2010-09-23 0:27 Hema HK
2010-09-29 7:00 ` Kalliguddi, Hema
[not found] ` <1285201660-26309-1-git-send-email-hemahk-l0cyMroinI0@public.gmane.org>
0 siblings, 2 replies; 8+ messages in thread
From: Hema HK @ 2010-09-23 0:27 UTC (permalink / raw)
To: linux-omap, linux-usb
Cc: Hema HK, Felipe Balbi, Tony Lindgren, Kevin Hilman,
Cousson, Benoit, Paul Walmsley
Removed the board_data parameter being passed to musb_platform_init function
as board data can be extracted from device structure which is already member of
musb structure.
Signed-off-by: Hema HK <hemahk@ti.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Cousson, Benoit <b-cousson@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>
---
drivers/usb/musb/blackfin.c | 2 +-
drivers/usb/musb/davinci.c | 2 +-
drivers/usb/musb/musb_core.c | 2 +-
drivers/usb/musb/musb_core.h | 2 +-
drivers/usb/musb/omap2430.c | 6 ++++--
drivers/usb/musb/tusb6010.c | 2 +-
6 files changed, 9 insertions(+), 7 deletions(-)
Index: linux-omap-pm/drivers/usb/musb/blackfin.c
===================================================================
--- linux-omap-pm.orig/drivers/usb/musb/blackfin.c
+++ linux-omap-pm/drivers/usb/musb/blackfin.c
@@ -323,7 +323,7 @@ int musb_platform_set_mode(struct musb *
return -EIO;
}
-int __init musb_platform_init(struct musb *musb, void *board_data)
+int __init musb_platform_init(struct musb *musb)
{
/*
Index: linux-omap-pm/drivers/usb/musb/davinci.c
===================================================================
--- linux-omap-pm.orig/drivers/usb/musb/davinci.c
+++ linux-omap-pm/drivers/usb/musb/davinci.c
@@ -376,7 +376,7 @@ int musb_platform_set_mode(struct musb *
return -EIO;
}
-int __init musb_platform_init(struct musb *musb, void *board_data)
+int __init musb_platform_init(struct musb *musb)
{
void __iomem *tibase = musb->ctrl_base;
u32 revision;
Index: linux-omap-pm/drivers/usb/musb/musb_core.c
===================================================================
--- linux-omap-pm.orig/drivers/usb/musb/musb_core.c
+++ linux-omap-pm/drivers/usb/musb/musb_core.c
@@ -2022,7 +2022,7 @@ bad_config:
* isp1504, non-OTG, etc) mostly hooking up through ULPI.
*/
musb->isr = generic_interrupt;
- status = musb_platform_init(musb, plat->board_data);
+ status = musb_platform_init(musb);
if (status < 0)
goto fail2;
Index: linux-omap-pm/drivers/usb/musb/musb_core.h
===================================================================
--- linux-omap-pm.orig/drivers/usb/musb/musb_core.h
+++ linux-omap-pm/drivers/usb/musb/musb_core.h
@@ -612,7 +612,7 @@ extern int musb_platform_get_vbus_status
#define musb_platform_get_vbus_status(x) 0
#endif
-extern int __init musb_platform_init(struct musb *musb, void *board_data);
+extern int __init musb_platform_init(struct musb *musb);
extern int musb_platform_exit(struct musb *musb);
#endif /* __MUSB_CORE_H__ */
Index: linux-omap-pm/drivers/usb/musb/omap2430.c
===================================================================
--- linux-omap-pm.orig/drivers/usb/musb/omap2430.c
+++ linux-omap-pm/drivers/usb/musb/omap2430.c
@@ -187,10 +187,12 @@ int musb_platform_set_mode(struct musb *
return 0;
}
-int __init musb_platform_init(struct musb *musb, void *board_data)
+int __init musb_platform_init(struct musb *musb)
{
u32 l;
- struct omap_musb_board_data *data = board_data;
+ struct device *dev = musb->controller;
+ struct musb_hdrc_platform_data *plat = dev->platform_data;
+ struct omap_musb_board_data *data = plat->board_data;
/* We require some kind of external transceiver, hooked
* up through ULPI. TWL4030-family PMICs include one,
Index: linux-omap-pm/drivers/usb/musb/tusb6010.c
===================================================================
--- linux-omap-pm.orig/drivers/usb/musb/tusb6010.c
+++ linux-omap-pm/drivers/usb/musb/tusb6010.c
@@ -1091,7 +1091,7 @@ err:
return -ENODEV;
}
-int __init musb_platform_init(struct musb *musb, void *board_data)
+int __init musb_platform_init(struct musb *musb)
{
struct platform_device *pdev;
struct resource *mem;
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH 2/9 v3] usb: musb: Remove board_data parameter from musb_platform_init()
2010-09-23 0:27 [PATCH 2/9 v3] usb: musb: Remove board_data parameter from musb_platform_init() Hema HK
@ 2010-09-29 7:00 ` Kalliguddi, Hema
[not found] ` <E0D41E29EB0DAC4E9F3FF173962E9E9402DB7FE390-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
[not found] ` <1285201660-26309-1-git-send-email-hemahk-l0cyMroinI0@public.gmane.org>
1 sibling, 1 reply; 8+ messages in thread
From: Kalliguddi, Hema @ 2010-09-29 7:00 UTC (permalink / raw)
To: linux-omap@vger.kernel.org, linux-usb@vger.kernel.org
Cc: Balbi, Felipe, Tony Lindgren, Kevin Hilman, Cousson, Benoit,
Paul Walmsley
Hi,
>-----Original Message-----
>From: Kalliguddi, Hema
>Sent: Thursday, September 23, 2010 5:58 AM
>To: linux-omap@vger.kernel.org; linux-usb@vger.kernel.org
>Cc: Kalliguddi, Hema; Balbi, Felipe; Tony Lindgren; Kevin
>Hilman; Cousson, Benoit; Paul Walmsley
>Subject: [PATCH 2/9 v3] usb: musb: Remove board_data parameter
>from musb_platform_init()
>
>Removed the board_data parameter being passed to
>musb_platform_init function
>as board data can be extracted from device structure which is
>already member of
>musb structure.
>
>Signed-off-by: Hema HK <hemahk@ti.com>
>Cc: Felipe Balbi <balbi@ti.com>
>Cc: Tony Lindgren <tony@atomide.com>
>Cc: Kevin Hilman <khilman@deeprootsystems.com>
>Cc: Cousson, Benoit <b-cousson@ti.com>
>Cc: Paul Walmsley <paul@pwsan.com>
>
>---
> drivers/usb/musb/blackfin.c | 2 +-
> drivers/usb/musb/davinci.c | 2 +-
> drivers/usb/musb/musb_core.c | 2 +-
> drivers/usb/musb/musb_core.h | 2 +-
> drivers/usb/musb/omap2430.c | 6 ++++--
> drivers/usb/musb/tusb6010.c | 2 +-
> 6 files changed, 9 insertions(+), 7 deletions(-)
>
>Index: linux-omap-pm/drivers/usb/musb/blackfin.c
>===================================================================
>--- linux-omap-pm.orig/drivers/usb/musb/blackfin.c
>+++ linux-omap-pm/drivers/usb/musb/blackfin.c
>@@ -323,7 +323,7 @@ int musb_platform_set_mode(struct musb *
> return -EIO;
> }
>
>-int __init musb_platform_init(struct musb *musb, void *board_data)
>+int __init musb_platform_init(struct musb *musb)
> {
>
> /*
>Index: linux-omap-pm/drivers/usb/musb/davinci.c
>===================================================================
>--- linux-omap-pm.orig/drivers/usb/musb/davinci.c
>+++ linux-omap-pm/drivers/usb/musb/davinci.c
>@@ -376,7 +376,7 @@ int musb_platform_set_mode(struct musb *
> return -EIO;
> }
>
>-int __init musb_platform_init(struct musb *musb, void *board_data)
>+int __init musb_platform_init(struct musb *musb)
> {
> void __iomem *tibase = musb->ctrl_base;
> u32 revision;
>Index: linux-omap-pm/drivers/usb/musb/musb_core.c
>===================================================================
>--- linux-omap-pm.orig/drivers/usb/musb/musb_core.c
>+++ linux-omap-pm/drivers/usb/musb/musb_core.c
>@@ -2022,7 +2022,7 @@ bad_config:
> * isp1504, non-OTG, etc) mostly hooking up through ULPI.
> */
> musb->isr = generic_interrupt;
>- status = musb_platform_init(musb, plat->board_data);
>+ status = musb_platform_init(musb);
> if (status < 0)
> goto fail2;
>
>Index: linux-omap-pm/drivers/usb/musb/musb_core.h
>===================================================================
>--- linux-omap-pm.orig/drivers/usb/musb/musb_core.h
>+++ linux-omap-pm/drivers/usb/musb/musb_core.h
>@@ -612,7 +612,7 @@ extern int musb_platform_get_vbus_status
> #define musb_platform_get_vbus_status(x) 0
> #endif
>
>-extern int __init musb_platform_init(struct musb *musb, void
>*board_data);
>+extern int __init musb_platform_init(struct musb *musb);
> extern int musb_platform_exit(struct musb *musb);
>
> #endif /* __MUSB_CORE_H__ */
>Index: linux-omap-pm/drivers/usb/musb/omap2430.c
>===================================================================
>--- linux-omap-pm.orig/drivers/usb/musb/omap2430.c
>+++ linux-omap-pm/drivers/usb/musb/omap2430.c
>@@ -187,10 +187,12 @@ int musb_platform_set_mode(struct musb *
> return 0;
> }
>
>-int __init musb_platform_init(struct musb *musb, void *board_data)
>+int __init musb_platform_init(struct musb *musb)
> {
> u32 l;
>- struct omap_musb_board_data *data = board_data;
>+ struct device *dev = musb->controller;
>+ struct musb_hdrc_platform_data *plat = dev->platform_data;
>+ struct omap_musb_board_data *data = plat->board_data;
>
> /* We require some kind of external transceiver, hooked
> * up through ULPI. TWL4030-family PMICs include one,
>Index: linux-omap-pm/drivers/usb/musb/tusb6010.c
>===================================================================
>--- linux-omap-pm.orig/drivers/usb/musb/tusb6010.c
>+++ linux-omap-pm/drivers/usb/musb/tusb6010.c
>@@ -1091,7 +1091,7 @@ err:
> return -ENODEV;
> }
>
>-int __init musb_platform_init(struct musb *musb, void *board_data)
>+int __init musb_platform_init(struct musb *musb)
> {
> struct platform_device *pdev;
> struct resource *mem;
>
Any comments on this patch?
Regards,
Hema
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/9 v3] usb: musb: Remove board_data parameter from musb_platform_init()
[not found] ` <E0D41E29EB0DAC4E9F3FF173962E9E9402DB7FE390-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
@ 2010-09-29 7:02 ` Felipe Balbi
0 siblings, 0 replies; 8+ messages in thread
From: Felipe Balbi @ 2010-09-29 7:02 UTC (permalink / raw)
To: Kalliguddi, Hema
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Balbi, Felipe,
Tony Lindgren, Kevin Hilman, Cousson, Benoit, Paul Walmsley
Hi,
On Wed, Sep 29, 2010 at 02:00:14AM -0500, Kalliguddi, Hema wrote:
>Any comments on this patch?
I need an ack from Mike (blackfin) and Kevin (DaVinci). Everything else
is fine by me.
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/9 v3] usb: musb: Remove board_data parameter from musb_platform_init()
[not found] ` <1285201660-26309-1-git-send-email-hemahk-l0cyMroinI0@public.gmane.org>
@ 2010-09-29 14:41 ` Kevin Hilman
[not found] ` <871v8c629u.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
0 siblings, 1 reply; 8+ messages in thread
From: Kevin Hilman @ 2010-09-29 14:41 UTC (permalink / raw)
To: Hema HK
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA, Felipe Balbi, Tony Lindgren,
Cousson, Benoit, Paul Walmsley
Hema HK <hemahk-l0cyMroinI0@public.gmane.org> writes:
> Removed the board_data parameter being passed to musb_platform_init function
> as board data can be extracted from device structure which is already member of
> musb structure.
>
> Signed-off-by: Hema HK <hemahk-l0cyMroinI0@public.gmane.org>
> Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
> Cc: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
> Cc: Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
> Cc: Cousson, Benoit <b-cousson-l0cyMroinI0@public.gmane.org>
> Cc: Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>
For the davinci changes:
Acked-by: Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
Kevin
> ---
> drivers/usb/musb/blackfin.c | 2 +-
> drivers/usb/musb/davinci.c | 2 +-
> drivers/usb/musb/musb_core.c | 2 +-
> drivers/usb/musb/musb_core.h | 2 +-
> drivers/usb/musb/omap2430.c | 6 ++++--
> drivers/usb/musb/tusb6010.c | 2 +-
> 6 files changed, 9 insertions(+), 7 deletions(-)
>
> Index: linux-omap-pm/drivers/usb/musb/blackfin.c
> ===================================================================
> --- linux-omap-pm.orig/drivers/usb/musb/blackfin.c
> +++ linux-omap-pm/drivers/usb/musb/blackfin.c
> @@ -323,7 +323,7 @@ int musb_platform_set_mode(struct musb *
> return -EIO;
> }
>
> -int __init musb_platform_init(struct musb *musb, void *board_data)
> +int __init musb_platform_init(struct musb *musb)
> {
>
> /*
> Index: linux-omap-pm/drivers/usb/musb/davinci.c
> ===================================================================
> --- linux-omap-pm.orig/drivers/usb/musb/davinci.c
> +++ linux-omap-pm/drivers/usb/musb/davinci.c
> @@ -376,7 +376,7 @@ int musb_platform_set_mode(struct musb *
> return -EIO;
> }
>
> -int __init musb_platform_init(struct musb *musb, void *board_data)
> +int __init musb_platform_init(struct musb *musb)
> {
> void __iomem *tibase = musb->ctrl_base;
> u32 revision;
> Index: linux-omap-pm/drivers/usb/musb/musb_core.c
> ===================================================================
> --- linux-omap-pm.orig/drivers/usb/musb/musb_core.c
> +++ linux-omap-pm/drivers/usb/musb/musb_core.c
> @@ -2022,7 +2022,7 @@ bad_config:
> * isp1504, non-OTG, etc) mostly hooking up through ULPI.
> */
> musb->isr = generic_interrupt;
> - status = musb_platform_init(musb, plat->board_data);
> + status = musb_platform_init(musb);
> if (status < 0)
> goto fail2;
>
> Index: linux-omap-pm/drivers/usb/musb/musb_core.h
> ===================================================================
> --- linux-omap-pm.orig/drivers/usb/musb/musb_core.h
> +++ linux-omap-pm/drivers/usb/musb/musb_core.h
> @@ -612,7 +612,7 @@ extern int musb_platform_get_vbus_status
> #define musb_platform_get_vbus_status(x) 0
> #endif
>
> -extern int __init musb_platform_init(struct musb *musb, void *board_data);
> +extern int __init musb_platform_init(struct musb *musb);
> extern int musb_platform_exit(struct musb *musb);
>
> #endif /* __MUSB_CORE_H__ */
> Index: linux-omap-pm/drivers/usb/musb/omap2430.c
> ===================================================================
> --- linux-omap-pm.orig/drivers/usb/musb/omap2430.c
> +++ linux-omap-pm/drivers/usb/musb/omap2430.c
> @@ -187,10 +187,12 @@ int musb_platform_set_mode(struct musb *
> return 0;
> }
>
> -int __init musb_platform_init(struct musb *musb, void *board_data)
> +int __init musb_platform_init(struct musb *musb)
> {
> u32 l;
> - struct omap_musb_board_data *data = board_data;
> + struct device *dev = musb->controller;
> + struct musb_hdrc_platform_data *plat = dev->platform_data;
> + struct omap_musb_board_data *data = plat->board_data;
>
> /* We require some kind of external transceiver, hooked
> * up through ULPI. TWL4030-family PMICs include one,
> Index: linux-omap-pm/drivers/usb/musb/tusb6010.c
> ===================================================================
> --- linux-omap-pm.orig/drivers/usb/musb/tusb6010.c
> +++ linux-omap-pm/drivers/usb/musb/tusb6010.c
> @@ -1091,7 +1091,7 @@ err:
> return -ENODEV;
> }
>
> -int __init musb_platform_init(struct musb *musb, void *board_data)
> +int __init musb_platform_init(struct musb *musb)
> {
> struct platform_device *pdev;
> struct resource *mem;
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/9 v3] usb: musb: Remove board_data parameter from musb_platform_init()
[not found] ` <871v8c629u.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
@ 2010-12-10 19:30 ` Sergei Shtylyov
2010-12-10 20:29 ` Greg KH
0 siblings, 1 reply; 8+ messages in thread
From: Sergei Shtylyov @ 2010-12-10 19:30 UTC (permalink / raw)
To: Greg KH
Cc: Kevin Hilman, Hema HK, linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA, Felipe Balbi, Tony Lindgren,
Cousson, Benoit, Paul Walmsley
Hello.
Kevin Hilman wrote:
>> Removed the board_data parameter being passed to musb_platform_init function
>> as board data can be extracted from device structure which is already member of
>> musb structure.
>> Signed-off-by: Hema HK <hemahk-l0cyMroinI0@public.gmane.org>
>> Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
>> Cc: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
>> Cc: Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
>> Cc: Cousson, Benoit <b-cousson-l0cyMroinI0@public.gmane.org>
>> Cc: Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>
> For the davinci changes:
> Acked-by: Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
> Kevin
>> ---
>> drivers/usb/musb/blackfin.c | 2 +-
>> drivers/usb/musb/davinci.c | 2 +-
>> drivers/usb/musb/musb_core.c | 2 +-
>> drivers/usb/musb/musb_core.h | 2 +-
>> drivers/usb/musb/omap2430.c | 6 ++++--
>> drivers/usb/musb/tusb6010.c | 2 +-
>> 6 files changed, 9 insertions(+), 7 deletions(-)
Grr. This misses changes to da8xx.c and am35x.c -- which breaks the
compilation for them!
Greg, could you drop it from your usb-next branch? Or should we send a patch
adding these glue layers?
WBR. Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/9 v3] usb: musb: Remove board_data parameter from musb_platform_init()
2010-12-10 19:30 ` Sergei Shtylyov
@ 2010-12-10 20:29 ` Greg KH
[not found] ` <20101210202906.GB23759-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
[not found] ` <4D038C9A.3070306@ru.mvista.com>
0 siblings, 2 replies; 8+ messages in thread
From: Greg KH @ 2010-12-10 20:29 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Kevin Hilman, Hema HK, linux-omap, linux-usb, Felipe Balbi,
Tony Lindgren, Cousson, Benoit, Paul Walmsley
On Fri, Dec 10, 2010 at 10:30:50PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> Kevin Hilman wrote:
>
> >>Removed the board_data parameter being passed to musb_platform_init function
> >>as board data can be extracted from device structure which is already member of
> >>musb structure.
>
> >>Signed-off-by: Hema HK <hemahk@ti.com>
> >>Cc: Felipe Balbi <balbi@ti.com>
> >>Cc: Tony Lindgren <tony@atomide.com>
> >>Cc: Kevin Hilman <khilman@deeprootsystems.com>
> >>Cc: Cousson, Benoit <b-cousson@ti.com>
> >>Cc: Paul Walmsley <paul@pwsan.com>
>
> >For the davinci changes:
>
> >Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
>
> >Kevin
>
> >>---
> >> drivers/usb/musb/blackfin.c | 2 +-
> >> drivers/usb/musb/davinci.c | 2 +-
> >> drivers/usb/musb/musb_core.c | 2 +-
> >> drivers/usb/musb/musb_core.h | 2 +-
> >> drivers/usb/musb/omap2430.c | 6 ++++--
> >> drivers/usb/musb/tusb6010.c | 2 +-
> >> 6 files changed, 9 insertions(+), 7 deletions(-)
>
> Grr. This misses changes to da8xx.c and am35x.c -- which breaks
> the compilation for them!
> Greg, could you drop it from your usb-next branch? Or should we
> send a patch adding these glue layers?
I can't drop patches from a git branch, sorry, it doesn't work that way
anymore.
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/9 v3] usb: musb: Remove board_data parameter from musb_platform_init()
[not found] ` <20101210202906.GB23759-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
@ 2010-12-10 21:07 ` Sergei Shtylyov
0 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2010-12-10 21:07 UTC (permalink / raw)
To: Greg KH
Cc: Sergei Shtylyov, Kevin Hilman, Hema HK,
linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA, Felipe Balbi, Tony Lindgren,
Cousson, Benoit, Paul Walmsley
Hello.
Greg KH wrote:
>>>> Removed the board_data parameter being passed to musb_platform_init function
>>>> as board data can be extracted from device structure which is already member of
>>>> musb structure.
>>>> Signed-off-by: Hema HK <hemahk-l0cyMroinI0@public.gmane.org>
>>>> Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
>>>> Cc: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
>>>> Cc: Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
>>>> Cc: Cousson, Benoit <b-cousson-l0cyMroinI0@public.gmane.org>
>>>> Cc: Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>
>>> For the davinci changes:
>>> Acked-by: Kevin Hilman <khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
>>> Kevin
>>>> ---
>>>> drivers/usb/musb/blackfin.c | 2 +-
>>>> drivers/usb/musb/davinci.c | 2 +-
>>>> drivers/usb/musb/musb_core.c | 2 +-
>>>> drivers/usb/musb/musb_core.h | 2 +-
>>>> drivers/usb/musb/omap2430.c | 6 ++++--
>>>> drivers/usb/musb/tusb6010.c | 2 +-
>>>> 6 files changed, 9 insertions(+), 7 deletions(-)
>> Grr. This misses changes to da8xx.c and am35x.c -- which breaks
>> the compilation for them!
>> Greg, could you drop it from your usb-next branch? Or should we
>> send a patch adding these glue layers?
> I can't drop patches from a git branch, sorry, it doesn't work that way
> anymore.
That's why I really prefer quilt to git. :-)
> greg k-h
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/9 v3] usb: musb: Remove board_data parameter from musb_platform_init()
[not found] ` <20101211174344.GA31964-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
@ 2010-12-12 13:55 ` Sergei Shtylyov
0 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2010-12-12 13:55 UTC (permalink / raw)
To: Greg KH
Cc: Kevin Hilman, Hema HK, linux-omap-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA, Felipe Balbi, Tony Lindgren,
Cousson, Benoit, Paul Walmsley
Hello.
On 11-12-2010 20:43, Greg KH wrote:
>>>>>> Removed the board_data parameter being passed to musb_platform_init function
>>>>>> as board data can be extracted from device structure which is already member of
>>>>>> musb structure.
>>>>>> Signed-off-by: Hema HK<hemahk-l0cyMroinI0@public.gmane.org>
>>>>>> Cc: Felipe Balbi<balbi-l0cyMroinI0@public.gmane.org>
>>>>>> Cc: Tony Lindgren<tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
>>>>>> Cc: Kevin Hilman<khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
>>>>>> Cc: Cousson, Benoit<b-cousson-l0cyMroinI0@public.gmane.org>
>>>>>> Cc: Paul Walmsley<paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>
>>>>> For the davinci changes:
>>>>> Acked-by: Kevin Hilman<khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
>>>>> Kevin
>>>>>> ---
>>>>>> drivers/usb/musb/blackfin.c | 2 +-
>>>>>> drivers/usb/musb/davinci.c | 2 +-
>>>>>> drivers/usb/musb/musb_core.c | 2 +-
>>>>>> drivers/usb/musb/musb_core.h | 2 +-
>>>>>> drivers/usb/musb/omap2430.c | 6 ++++--
>>>>>> drivers/usb/musb/tusb6010.c | 2 +-
>>>>>> 6 files changed, 9 insertions(+), 7 deletions(-)
>>>> Grr. This misses changes to da8xx.c and am35x.c -- which breaks
>>>> the compilation for them!
>>>> Greg, could you drop it from your usb-next branch? Or should we
>>>> send a patch adding these glue layers?
>>> I can't drop patches from a git branch, sorry, it doesn't work that way
>>> anymore.
>> OTOH, you could revert it (as breaking the build). Dunno if that
>> makes sense...
> Again, I trust the musb maintainer here to handle this type of thing,
> not me. So take it up with him.
Done already. And he's on the CC here too...
> thanks,
> greg k-h
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-12-12 13:55 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-23 0:27 [PATCH 2/9 v3] usb: musb: Remove board_data parameter from musb_platform_init() Hema HK
2010-09-29 7:00 ` Kalliguddi, Hema
[not found] ` <E0D41E29EB0DAC4E9F3FF173962E9E9402DB7FE390-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2010-09-29 7:02 ` Felipe Balbi
[not found] ` <1285201660-26309-1-git-send-email-hemahk-l0cyMroinI0@public.gmane.org>
2010-09-29 14:41 ` Kevin Hilman
[not found] ` <871v8c629u.fsf-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org>
2010-12-10 19:30 ` Sergei Shtylyov
2010-12-10 20:29 ` Greg KH
[not found] ` <20101210202906.GB23759-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2010-12-10 21:07 ` Sergei Shtylyov
[not found] ` <4D038C9A.3070306@ru.mvista.com>
[not found] ` <20101211174344.GA31964@kroah.com>
[not found] ` <20101211174344.GA31964-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2010-12-12 13:55 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).