From: Kevin Hilman <khilman@deeprootsystems.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Paul Walmsley <paul@pwsan.com>, Tony Lindgren <tony@atomide.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Andrew Lunn <andrew@lunn.ch>,
Linus Walleij <linus.walleij@linaro.org>,
Daniel Walker <dwalker@fifo99.com>,
Lennert Buytenhek <kernel@wantstofly.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
David Brown <davidb@codeaurora.org>,
Arnd Bergmann <arnd@arndb.de>,
Stephen Warren <swarren@wwwdotorg.org>,
Ben Dooks <ben-linux@fluff.org>,
Alexander Schulz <alex@shark-linux.de>,
Andrew Victor <linux@maxim.org.za>,
Kyungmin Park <kyungmin.park@samsung.com>,
Sascha Hauer <kernel@pengutronix.de>,
Olof
Subject: Re: [PATCH] arm: sched: stop sched_clock() during suspend
Date: Mon, 22 Oct 2012 10:05:25 -0700 [thread overview]
Message-ID: <873916h1yi.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1350906877-19410-1-git-send-email-balbi@ti.com> (Felipe Balbi's message of "Mon, 22 Oct 2012 14:54:37 +0300")
+Colin Cross, Barry Song also
Felipe Balbi <balbi@ti.com> writes:
> The scheduler imposes a requirement to sched_clock()
> which is to stop the clock during suspend, if we don't
> do that IRQ threads will be rescheduled in the future
> which might cause transfers to timeout depending on
> how driver is written.
It's not just about IRQ threads, it's about RT throttling. IOW, not
just IRQ threads will be postponed, but all RT tasks will be throttled
temporarily as well.
The changelog should also mention that this has an inconvenient side
effect of stopping the printk times during suspend. Based on the
original thread where this feature was discussed and introduced, some
platforms wanted to opt out of this behavior[1], so the optional API was
added.
However, in light of RT throttling, this a correctness issue for process
accounting, so I agree that this should be done for all platforms
instead of providing an optional 'needs suspend' version of the API,
even though it means printk times no longer reflect time spent
suspended.
After a discussion with peterz on this topic, it seems that x86
already ensures that sched_clock stops during suspend for similar
reasons[2].
The question then is whether this is a fix that belongs in v3.7.
Technically, it is not a regression, so I think this should probably be
v3.8 material. If that's the decision, then the threaded IRQ support
for the OMAP I2C driver needs to be reverted for v3.7 until this fix is merged.
Kevin
[1] http://marc.info/?l=linux-arm-kernel&m=134307004508708&w=2
[2] http://marc.info/?l=linux-arm-kernel&m=135065529907297&w=2
next prev parent reply other threads:[~2012-10-22 17:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 11:54 [PATCH] arm: sched: stop sched_clock() during suspend Felipe Balbi
2012-10-22 12:07 ` Felipe Balbi
2012-10-22 17:05 ` Kevin Hilman [this message]
2012-10-22 22:28 ` Linus Walleij
2012-10-23 9:22 ` Russell King - ARM Linux
2012-10-23 14:17 ` Kevin Hilman
2012-10-23 16:03 ` Russell King - ARM Linux
2012-10-23 17:24 ` Felipe Balbi
2012-10-23 5:57 ` [PATCH v2] " Felipe Balbi
2012-10-23 14:14 ` Kevin Hilman
2012-10-23 10:11 ` [PATCH] " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873916h1yi.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=alex@shark-linux.de \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=kernel@pengutronix.de \
--cc=kernel@wantstofly.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=paul@pwsan.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=santosh.shilimkar@ti.com \
--cc=swarren@wwwdotorg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).