Re: [PATCH 2/3] mmc: omap_hsmmc: Add fclk frequency to debufs

[Chris Ball <cjb@laptop.org>]

Hi,

On Thu, Apr 19 2012, S, Venkatraman wrote:
>>> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
>>> index d15b149..d046ba2 100644
>>> --- a/drivers/mmc/host/omap_hsmmc.c
>>> +++ b/drivers/mmc/host/omap_hsmmc.c
>>> @@ -1683,8 +1683,9 @@ static int omap_hsmmc_regs_show(struct seq_file *s, void *data)
>>>       if (host->pdata->get_context_loss_count)
>>>               context_loss = host->pdata->get_context_loss_count(host->dev);
>>>
>>> -     seq_printf(s, "mmc%d:\n ctx_loss:\t%d:%d\n\nregs:\n",
>>> -                     mmc->index, host->context_loss, context_loss);
>>> +     seq_printf(s, "mmc%d:\n ctx_loss:\t%d:%d\n fclk:\t\t%lu Hz\n\nregs:\n",
>>> +             mmc->index, host->context_loss, context_loss,
>>
>> Minor nit, but it looks like this line breaks indentation.
>
> It does ? I thought I actually fixed the indentation of the original
> patch by removing a tabstop, as it was going
> too far into the right.
> checkpatch.pl doesn't complain about it.

After applying it, omap_hsmmc.c looks like this here:

        seq_printf(s, "mmc%d:\n ctx_loss:\t%d:%d\n fclk:\t\t%lu Hz\n\nregs:\n",
                mmc->index, host->context_loss, context_loss,
                        clk_get_rate(host->fclk));

(That's with tabs converted to spaces for e-mail.)

So you're right that the original lines are indented a character too far
to the right, but after your patch there are different indentations used
for lines 2 and 3 above, so that's worse than it was before.

All of the seq_printf() calls in omap_hsmmc.c have the same indentation
one space too far to the right.  I guess we should just stick with it.

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child