From: Kevin Hilman <khilman@ti.com>
To: "DebBarma, Tarun Kanti" <tarun.kanti@ti.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>,
linux-omap@vger.kernel.org, tony@atomide.com,
linux-arm-kernel@lists.infradead.org, charu@ti.com
Subject: Re: [PATCH v7 00/26] gpio/omap: driver cleanup and fixes
Date: Mon, 26 Sep 2011 16:10:05 -0700 [thread overview]
Message-ID: <8739fi99yq.fsf@ti.com> (raw)
In-Reply-To: <CAC83ZvLfCOjKja1rZ6GB4bmn_KrcjitTJZJsa5jy01QVj2OXXw@mail.gmail.com> (Tarun Kanti DebBarma's message of "Sat, 24 Sep 2011 16:11:52 +0530")
"DebBarma, Tarun Kanti" <tarun.kanti@ti.com> writes:
[...]
> As pointed out by Kevin, debounce clock was not getting disabled.
> In my testing I was somehow grepping CORE power domain instead
> of PER power domain and hence missed it. The fix for the debounce
> clock issue is at the end of the email.
>
> - Have re-based the for_3.2/gpio-cleanup branch against 3.1-rc6.
> - Dropped [PATCH 26/26] gpio/omap: add dbclk aliases for all gpio modules
> as suggested by Kevin since it's already taken care by hwmod.
> - Added the debounce clock fix in the end.
That debounce fix definitely makes things look better, but it's not
solving the problem...
> With above, PER is hitting low power state in Suspend and Idle path.
>
> Have pushed a branch at below URL with mentioned changes.
> git://gitorious.org/omap-sw-develoment/linux-omap-dev.git
> for_3.2/kevin/gpio-cleanup
I tested your branch on my 3430/n900 and PER is still not hitting
retention. Setting all debounce values in the board file to zero using
the patch below[1] makes PER hit retention again.
Assuming you don't have an n900 to test with, I suggest you just copy
the GPIO keys init from board-rx51-peripherals.c (or some of it) into
the board file you are testing with.
The problem is most likely be related to having more than one GPIO in a
bank with debounce enabled, or more than one bank with GPIOs enabled and
your current test is not be catching it.
Kevin
[1]
diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c
index 5a886cd..1853194 100644
--- a/arch/arm/mach-omap2/board-rx51-peripherals.c
+++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
@@ -207,7 +207,7 @@ static void __init rx51_charger_init(void)
#define RX51_GPIO_LOCK_BUTTON 113
#define RX51_GPIO_PROXIMITY 89
-#define RX51_GPIO_DEBOUNCE_TIMEOUT 10
+#define RX51_GPIO_DEBOUNCE_TIMEOUT 0
static struct gpio_keys_button rx51_gpio_keys[] = {
{
next prev parent reply other threads:[~2011-09-26 23:10 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 13:02 [PATCH v7 00/26] gpio/omap: driver cleanup and fixes Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 01/26] gpio/omap: remove dependency on gpio_bank_count Tarun Kanti DebBarma
2011-09-21 14:41 ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 02/26] gpio/omap: use flag to identify wakeup domain Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 03/26] gpio/omap: make gpio_context part of gpio_bank structure Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 04/26] gpio/omap: fix pwrdm_post_transition call sequence Tarun Kanti DebBarma
2011-09-21 14:47 ` Tony Lindgren
2011-09-26 23:15 ` Kevin Hilman
2011-09-13 13:02 ` [PATCH v7 05/26] gpio/omap: handle save/restore context in GPIO driver Tarun Kanti DebBarma
2011-09-21 14:48 ` Tony Lindgren
2011-09-26 23:22 ` Kevin Hilman
2011-09-13 13:02 ` [PATCH v7 06/26] gpio/omap: make non-wakeup GPIO part of pdata Tarun Kanti DebBarma
2011-09-21 14:49 ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 07/26] gpio/omap: avoid cpu checks during module ena/disable Tarun Kanti DebBarma
2011-09-21 14:49 ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 08/26] gpio/omap: further cleanup using wkup_en register Tarun Kanti DebBarma
2011-09-21 14:49 ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 09/26] gpio/omap: use level/edge detect reg offsets Tarun Kanti DebBarma
2011-09-21 14:55 ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 10/26] gpio/omap: remove hardcoded offsets in context save/restore Tarun Kanti DebBarma
2011-09-21 14:55 ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 11/26] gpio/omap: cleanup set_gpio_triggering function Tarun Kanti DebBarma
2011-09-21 14:55 ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 12/26] gpio/omap: cleanup omap_gpio_mod_init function Tarun Kanti DebBarma
2011-09-21 14:56 ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 13/26] gpio/omap: use pinctrl offset instead of macro Tarun Kanti DebBarma
2011-09-21 14:56 ` Tony Lindgren
2011-09-21 15:03 ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 14/26] gpio/omap: remove unnecessary bit-masking for read access Tarun Kanti DebBarma
2011-09-14 11:19 ` Sergei Shtylyov
2011-09-14 13:08 ` DebBarma, Tarun Kanti
2011-09-13 13:02 ` [PATCH v7 15/26] gpio/omap: remove bank->method & METHOD_* macros Tarun Kanti DebBarma
2011-09-21 15:05 ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 16/26] gpio/omap: fix bankwidth for OMAP7xx MPUIO Tarun Kanti DebBarma
2011-09-21 15:05 ` Tony Lindgren
2011-09-13 13:02 ` [PATCH v7 17/26] gpio/omap: use pm-runtime framework Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 18/26] gpio/omap: optimize suspend and resume functions Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 19/26] gpio/omap: cleanup prepare_for_idle and resume_after_idle Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 20/26] gpio/omap: skip operations in runtime callbacks Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 21/26] gpio/omap: remove omap_gpio_save_context overhead Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 22/26] gpio/omap: save and restore debounce registers Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 23/26] gpio/omap: enable irq at the end of all configuration in restore Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 24/26] gpio/omap: restore OE only after setting the output level Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 25/26] gpio/omap: handle set_dataout reg capable IP on restore Tarun Kanti DebBarma
2011-09-13 13:02 ` [PATCH v7 26/26] gpio/omap: add dbclk aliases for all gpio modules Tarun Kanti DebBarma
2011-09-21 15:13 ` Tony Lindgren
2011-09-22 15:27 ` [PATCH v7 00/26] gpio/omap: driver cleanup and fixes DebBarma, Tarun Kanti
2011-09-22 20:36 ` Kevin Hilman
2011-09-23 4:24 ` DebBarma, Tarun Kanti
2011-09-22 23:57 ` Kevin Hilman
2011-09-24 3:56 ` DebBarma, Tarun Kanti
2011-09-24 8:50 ` Santosh Shilimkar
2011-09-24 10:41 ` DebBarma, Tarun Kanti
2011-09-26 18:39 ` Kevin Hilman
2011-09-26 22:10 ` DebBarma, Tarun Kanti
2011-09-26 22:59 ` Kevin Hilman
2011-09-26 23:10 ` Kevin Hilman [this message]
2011-09-27 14:31 ` DebBarma, Tarun Kanti
2011-09-27 16:22 ` Kevin Hilman
2011-09-27 23:42 ` DebBarma, Tarun Kanti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739fi99yq.fsf@ti.com \
--to=khilman@ti.com \
--cc=charu@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=tarun.kanti@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox