From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 5/5 v4] mfd: omap: usb: Runtime PM support Date: Mon, 29 Aug 2011 13:47:39 -0700 Message-ID: <8739gkrllg.fsf@ti.com> References: <1312899309-24067-1-git-send-email-keshava_mgowda@ti.com> <1312899309-24067-2-git-send-email-keshava_mgowda@ti.com> <1312899309-24067-3-git-send-email-keshava_mgowda@ti.com> <1312899309-24067-4-git-send-email-keshava_mgowda@ti.com> <1312899309-24067-5-git-send-email-keshava_mgowda@ti.com> <1312899309-24067-6-git-send-email-keshava_mgowda@ti.com> <87mxesrr1g.fsf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog126.obsmtp.com ([74.125.149.155]:48896 "EHLO na3sys009aog126.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754684Ab1H2Urn (ORCPT ); Mon, 29 Aug 2011 16:47:43 -0400 In-Reply-To: <87mxesrr1g.fsf@ti.com> (Kevin Hilman's message of "Mon, 29 Aug 2011 11:50:03 -0700") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Keshava Munegowda Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, balbi@ti.com, gadiyar@ti.com, sameo@linux.intel.com, parthab@india.ti.com, tony@atomide.com, b-cousson@ti.com, paul@pwsan.com, johnstul@us.ibm.com, vishwanath.bs@ti.com, Jassi Brar Kevin Hilman writes: > Keshava Munegowda writes: > >> From: Keshava Munegowda >> >> The usbhs core driver does not enable/disable the intefrace and >> fucntional clocks; These clocks are handled by hwmod and runtime pm, >> hence insted of the clock enable/disable, the runtime pm APIS are >> used. however,the port clocks are handled by the usbhs core. >> >> Signed-off-by: Keshava Munegowda > > General comment: all usage of pm_runtime_put_sync() can likely be > replaced by the asynchronous versions. I don't currently see why the > synchronous verions are needed here. > > Other than that, the runtime PM parts of this look OK to me. After > changing to asynchonous puts, feel free to add: > > Reviewed-by: Kevin Hilman oops, this should've been in response to your v8 version. Kevin > > Also, after a quick glance, it looks like this version of the series > addresses the problems seen by Jassi Brar with the TLL reset[1]. Please > confirm. > > Speaking of which, it's helpful to Cc folks who have had comments on > previous versions of your series so they are sure they're previous > issues are addressed. I've Cc'd Jassi Brar. > > Thanks, > > Kevin > > [1] http://marc.info/?l=linux-omap&m=130921260703865&w=2