linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Vasiliy Kulikov <segooon@gmail.com>, Tony Lindgren <tony@atomide.com>
Cc: kernel-janitors@vger.kernel.org,
	"Govindraj.R" <govindraj.raja@ti.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Alan Cox <alan@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] serial: omap-serial: fix signess error
Date: Tue, 12 Oct 2010 11:39:36 -0700	[thread overview]
Message-ID: <8739sb1cif.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1286731715-17908-1-git-send-email-segooon@gmail.com> (Vasiliy Kulikov's message of "Sun, 10 Oct 2010 21:28:35 +0400")

[adding linux-omap list]

Vasiliy Kulikov <segooon@gmail.com> writes:

> "ret" is unsigned, so check for (ret < 0) made no sense.
> Made it signed.
>
> Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
> ---
>  I cannot compile this driver, so it is not tested.

Acked-by: Kevin Hilman <khilman@deeprootsystems.com>

Since the original driver is being queued via the omap tree, we can
queue this one as well.

Tony, can you add this one to the 2.6.37 queue?

Thanks,

Kevin

>  drivers/serial/omap-serial.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/serial/omap-serial.c b/drivers/serial/omap-serial.c
> index 2ee1d32..14365f7 100644
> --- a/drivers/serial/omap-serial.c
> +++ b/drivers/serial/omap-serial.c
> @@ -1055,7 +1055,7 @@ static void serial_omap_rx_timeout(unsigned long uart_no)
>  {
>  	struct uart_omap_port *up = ui[uart_no];
>  	unsigned int curr_dma_pos, curr_transmitted_size;
> -	unsigned int ret = 0;
> +	int ret = 0;
>  
>  	curr_dma_pos = omap_get_dma_dst_pos(up->uart_dma.rx_dma_channel);
>  	if ((curr_dma_pos == up->uart_dma.prev_rx_dma_pos) ||

       reply	other threads:[~2010-10-12 18:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1286731715-17908-1-git-send-email-segooon@gmail.com>
2010-10-12 18:39 ` Kevin Hilman [this message]
2010-10-12 20:21   ` [PATCH] serial: omap-serial: fix signess error Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8739sb1cif.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=alan@linux.intel.com \
    --cc=govindraj.raja@ti.com \
    --cc=gregkh@suse.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=segooon@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).