* Re: [PATCH] serial: omap-serial: fix signess error [not found] <1286731715-17908-1-git-send-email-segooon@gmail.com> @ 2010-10-12 18:39 ` Kevin Hilman 2010-10-12 20:21 ` Tony Lindgren 0 siblings, 1 reply; 2+ messages in thread From: Kevin Hilman @ 2010-10-12 18:39 UTC (permalink / raw) To: Vasiliy Kulikov, Tony Lindgren Cc: kernel-janitors, Govindraj.R, Greg Kroah-Hartman, Alan Cox, linux-kernel, linux-omap [adding linux-omap list] Vasiliy Kulikov <segooon@gmail.com> writes: > "ret" is unsigned, so check for (ret < 0) made no sense. > Made it signed. > > Signed-off-by: Vasiliy Kulikov <segooon@gmail.com> > --- > I cannot compile this driver, so it is not tested. Acked-by: Kevin Hilman <khilman@deeprootsystems.com> Since the original driver is being queued via the omap tree, we can queue this one as well. Tony, can you add this one to the 2.6.37 queue? Thanks, Kevin > drivers/serial/omap-serial.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/serial/omap-serial.c b/drivers/serial/omap-serial.c > index 2ee1d32..14365f7 100644 > --- a/drivers/serial/omap-serial.c > +++ b/drivers/serial/omap-serial.c > @@ -1055,7 +1055,7 @@ static void serial_omap_rx_timeout(unsigned long uart_no) > { > struct uart_omap_port *up = ui[uart_no]; > unsigned int curr_dma_pos, curr_transmitted_size; > - unsigned int ret = 0; > + int ret = 0; > > curr_dma_pos = omap_get_dma_dst_pos(up->uart_dma.rx_dma_channel); > if ((curr_dma_pos == up->uart_dma.prev_rx_dma_pos) || ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: omap-serial: fix signess error 2010-10-12 18:39 ` [PATCH] serial: omap-serial: fix signess error Kevin Hilman @ 2010-10-12 20:21 ` Tony Lindgren 0 siblings, 0 replies; 2+ messages in thread From: Tony Lindgren @ 2010-10-12 20:21 UTC (permalink / raw) To: Kevin Hilman Cc: Vasiliy Kulikov, kernel-janitors, Govindraj.R, Greg Kroah-Hartman, Alan Cox, linux-kernel, linux-omap * Kevin Hilman <khilman@deeprootsystems.com> [101012 11:30]: > [adding linux-omap list] > > Vasiliy Kulikov <segooon@gmail.com> writes: > > > "ret" is unsigned, so check for (ret < 0) made no sense. > > Made it signed. > > > > Signed-off-by: Vasiliy Kulikov <segooon@gmail.com> > > --- > > I cannot compile this driver, so it is not tested. > > Acked-by: Kevin Hilman <khilman@deeprootsystems.com> > > Since the original driver is being queued via the omap tree, we can > queue this one as well. > > Tony, can you add this one to the 2.6.37 queue? Thanks, adding into omap-for-linus. Regards, Tony ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-12 20:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1286731715-17908-1-git-send-email-segooon@gmail.com>
2010-10-12 18:39 ` [PATCH] serial: omap-serial: fix signess error Kevin Hilman
2010-10-12 20:21 ` Tony Lindgren
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).