public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Tarun Kanti DebBarma <tarun.kanti@ti.com>
Cc: linux-omap@vger.kernel.org, R Sricharan <r.sricharan@ti.com>
Subject: Re: [PATCH v2] OMAP:GPTIMER:1ms tick generation correction
Date: Mon, 21 Jun 2010 08:54:16 -0700	[thread overview]
Message-ID: <8739wg2xg7.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1277151798-26232-1-git-send-email-tarun.kanti@ti.com> (Tarun Kanti DebBarma's message of "Tue\, 22 Jun 2010 01\:53\:18 +0530")

Tarun Kanti DebBarma <tarun.kanti@ti.com> writes:

> Generation of 1ms granular GPTIMER events using 32KHz or system
> clocks as inputs does not have whole number count value to load
> into the register. This inaccurate count value with respect to 1ms
> period leads to time drift subsequently. OMAP3 and later silicons
> have dedicated registers for GPTIMER1, GPTIMER2 and GPTIMER10,
> which can be programmed with computed values to keep this error
> controlled within specified limit.
>
> Version 2:
> (i) optimized omap_dm_timer_ms_correction() function and corrected
> error in computing the positive and negative increments.
> (ii) typo corrections in comment section and warning removal related
> to 80-character limit
>
> Tested on Zoom3 using Linus tree.
>
> Signed-off-by: R Sricharan <r.sricharan@ti.com>
> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com>

Please coordinate this change with the GPTIMER hwmod changes.  The timers
that have/need this feature should be flagged at the hwmod level (probably by
a dev_attr flag.)

Kevin

  parent reply	other threads:[~2010-06-21 15:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-21 20:23 [PATCH v2] OMAP:GPTIMER:1ms tick generation correction Tarun Kanti DebBarma
2010-06-21 10:44 ` Nishanth Menon
2010-06-21 12:51   ` DebBarma, Tarun Kanti
2010-06-21 12:56     ` Nishanth Menon
2010-06-21 13:19       ` DebBarma, Tarun Kanti
2010-06-21 13:26         ` Nishanth Menon
2010-06-21 13:33           ` DebBarma, Tarun Kanti
2010-06-21 14:21   ` David Brownell
2010-06-21 14:30     ` DebBarma, Tarun Kanti
2010-06-21 15:54 ` Kevin Hilman [this message]
2010-06-22  3:38   ` DebBarma, Tarun Kanti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8739wg2xg7.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=r.sricharan@ti.com \
    --cc=tarun.kanti@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox