From: Kalle Valo <kalle.valo@iki.fi>
To: Francisco Alecrim <alecrim@gmail.com>
Cc: linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH] board-n8x0: add USB initialization
Date: Mon, 01 Mar 2010 10:37:06 +0200 [thread overview]
Message-ID: <873a0kfnf1.fsf@purkki.valot.fi> (raw)
In-Reply-To: <309201e1002281933k1fb52d29sa47b2f4eca35861d@mail.gmail.com> (Francisco Alecrim's message of "Sun\, 28 Feb 2010 23\:33\:45 -0400")
Francisco Alecrim <alecrim@gmail.com> writes:
> Hi Kalle,
Hi again Francisco,
> On Sun, Feb 28, 2010 at 2:57 PM, Kalle Valo <kalle.valo@iki.fi> wrote:
> Please do not add my Signed-off-by unless I have explicitly added it.
> And I don't recall giving it to this patch, so it can be removed.
>
>
> I got the initial code from http://www.valot.fi/kalle/n8x0/patches/n8x0-add/
> 2009-07-31-12:15/07-n8x0-add-usb-support.patch . I just re-organized some
> variables. So I didn't remove your Signed-off-by.
Hehe, I had totally forgotten that patch! Sorry :)
> And I merged your patch to Tony's code http://www.mail-archive.com/
> linux-omap@vger.kernel.org/msg21443.html . So I kept his Signed-off-by.
[...]
> Sorry! I was not sure about keep or not these Signed-off-by. Do you
> want me to re-send it without your Signed-off-by?
No, this was my mistake. Please don't remove the Signed-off-by line.
But when you improve a patch originally implemented by somene else
it's a good practise to mention the history of the patch. For example,
"Based on Kalle's and Tony's patches", or something like that, is
enough IMHO.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-03-01 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-28 1:50 [PATCH] board-n8x0: add USB initialization Francisco Alecrim
2010-02-28 18:57 ` Kalle Valo
2010-03-01 4:07 ` Francisco Alecrim
[not found] ` <309201e1002281933k1fb52d29sa47b2f4eca35861d@mail.gmail.com>
2010-03-01 8:37 ` Kalle Valo [this message]
2010-03-01 6:53 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873a0kfnf1.fsf@purkki.valot.fi \
--to=kalle.valo@iki.fi \
--cc=alecrim@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox