Re: [PATCH v2 1/3] OMAP3:zoom2: Add support for OMAP3 Zoom2 board

[Kevin Hilman <khilman@deeprootsystems.com>]

"Christensen, Mikkel" <mlc@ti.com> writes:

> Hi Kevin
>
> On Fri, May 15, 2009 at 13:04:42, Kevin Hilman wrote:
>> > ---
>> >  arch/arm/mach-omap2/board-zoom2-debugboard.c |  165
>> ++++++++++++++++++++++++++
>> >  arch/arm/mach-omap2/board-zoom2.c            |  109 
>> +++++++++++++++++
>> >  2 files changed, 274 insertions(+), 0 deletions(-)  create mode
>> > 100644 arch/arm/mach-omap2/board-zoom2-debugboard.c
>> >  create mode 100644 arch/arm/mach-omap2/board-zoom2.c
>> >
>> > diff --git a/arch/arm/mach-omap2/board-zoom2-debugboard.c
>> > b/arch/arm/mach-omap2/board-zoom2-debugboard.c
>> > new file mode 100644
>> > index 0000000..e89b3af
>> > --- /dev/null
>> > +++ b/arch/arm/mach-omap2/board-zoom2-debugboard.c
>> > @@ -0,0 +1,165 @@
>> > +/*
>> > + * arch/arm/mach-omap2/board-zoom2-debugboard.c
>> 
>> Can you drop the filename here, and in the other files as well.
>
> Sure I can do the change. Is this a new convention being used? I can see the file name in many other files as well.

Yes, it still exists in many files but is not needed for new files.

First, listing the filename is a bit redundant, but also those names
tend to get out of date as files move around and the names are not
updated.

Kevin