Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

[Kevin Hilman <khilman@ti.com>]

"Munegowda, Keshava" <keshava_mgowda@ti.com> writes:

> On Wed, Jul 11, 2012 at 3:59 PM, Samuel Ortiz <sameo@linux.intel.com> wrote:
>> Hi Keshava, Kevin,
>>
>> On Fri, Jul 06, 2012 at 05:29:00PM +0530, Munegowda, Keshava wrote:
>>> Samuel
>>>           I have sent that patch to disable the ehci in
>>> omap2plus_defconfig; after merging that
>>> please merge this patch too. This will fix the crashes in during boot
>>> with NFS in beagleXM
>> I'm going to apply and push this patch for 3.5, and the defconfig patch can be
>> pushed through Tony's tree.
>> Kevin, could you please ACK it ?
>>
>> Cheers,
>> Samuel.
>>
>
> Thanks Samuel
>
> Kevin,
>     need your ack for this.

You never answered earlier questions from myself or Russ Dill about the
more targetted patches from Russ:

   ARM: OMAP: USB: Fixup ehci_hcd_omap_probe error path
   Fix OMAP EHCI suspend/resume failure (i693) '354ab856' causes

Also, your current $SUBJECT patch is large and not well
described. e.g. what is "not correct" and why.  Why does it fix the
problems mentioned?  The original changelog mentions the "core retention
issue" but this patch does nothing to address that.  If you want an Ack
from me, especially because I'm not an expert in this IP, you'll have to
describe things in a way that I can understand.

IMO, at this point of the dev cycle (trying to stabilize v3.5), the full
cleanup/fix of this feature will need to be done for v3.6.  For v3.5, I
think the two patches from Russ Dill should be merged.   They are
targetted fixes and very well described.

Kevin

> The commit id 354ab8567ae3107a8cbe7228c3181990ba598aac titled
> "Fix OMAP EHCI suspend/resume failure (i693)",
> is handling the clocks in ehci driver which is not correct,
> it will be through the usb host driver ( /mfd/omap-usb_host.c )  exporting
> APIs to ehci driver to handler the port clocks.
>
> for now, this patch is necessary to remove the
>  commit id 354ab8567ae3107a8cbe7228c3181990ba598aac titled
> "Fix OMAP EHCI suspend/resume failure (i693)",
>
> regards
> keshava
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html