From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Date: Mon, 22 Aug 2011 16:58:32 -0700 Message-ID: <874o19gfrr.fsf@ti.com> References: <1312979122-5896-1-git-send-email-j-keerthy@ti.com> <1312979122-5896-7-git-send-email-j-keerthy@ti.com> <20110810124629.GJ12882@legolas.emea.dhcp.ti.com> <20110811103658.GG27742@legolas.emea.dhcp.ti.com> <20110811141248.GK28500@legolas.emea.dhcp.ti.com> <20110811185408.GB15970@legolas.emea.dhcp.ti.com> <20110811185558.GC15970@legolas.emea.dhcp.ti.com> <4E444B8F.9060908@ti.com> <4E449D65.9000004@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog111.obsmtp.com ([74.125.149.205]:33575 "EHLO na3sys009aog111.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752183Ab1HVX6i (ORCPT ); Mon, 22 Aug 2011 19:58:38 -0400 Received: by mail-gx0-f181.google.com with SMTP id 9so5749931gxk.12 for ; Mon, 22 Aug 2011 16:58:37 -0700 (PDT) In-Reply-To: <4E449D65.9000004@ti.com> (Rajendra Nayak's message of "Fri, 12 Aug 2011 08:56:29 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Rajendra Nayak Cc: Roger Quadros , balbi@ti.com, "J, KEERTHY" , Tony Lindgren , lm-sensors@lm-sensors.org, vishwanath.bs@ti.com, linux-omap@vger.kernel.org, b-cousson@ti.com, Russell King , Linux ARM Kernel Mailing List , khali@linux-fr.org, guenter.roeck@ericsson.com Rajendra Nayak writes: [...] > FWIK, its a one time requirement to set the clock rate to the > right rate the device can operate in based on what a platform > supports. Except $SUBJECT patch hard-codes the clock rate for all platforms in the driver. If the clock rate is to be platform-specific, it should be done in platform-specific code. Kevin