From: Kevin Hilman <khilman@ti.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-pm@lists.linux-foundation.org,
Linux OMAP <linux-omap@vger.kernel.org>
Subject: Re: pm_runtime_suspended() can be false if RPM_SUSPENDED
Date: Mon, 11 Jul 2011 13:14:58 -0700 [thread overview]
Message-ID: <874o2sy3p9.fsf@ti.com> (raw)
In-Reply-To: <201107112202.48280.rjw@sisk.pl> (Rafael J. Wysocki's message of "Mon, 11 Jul 2011 22:02:48 +0200")
"Rafael J. Wysocki" <rjw@sisk.pl> writes:
[...]
>>
>> However, based on the pm_runtime_set_active() problem you mentioned
>> above, I'm not sure this will help either, since what the PM domain's
>> noirq callback will want to do will be based on the actual device
>> hardware state, not on the PM core's view of the device state.
>
> Yes. For devices whose runtime PM is never enabled, this is quite clear
> (we must assume they are operational). For devices whose runtime PM is
> temporarily disabled and the reenabled, it's not that clear, but at
> least for the system suspend case we may require drivers not to use
> pm_runtime_set_active/suspended() in their callbacks, so that we may
> assume that the status hasn't changed between .suspend() and .resume().
>
> So, I think your approach (to check power.runtime_status) is correct in this
> respect.
OK, I'll just directly check power.runtime_status in the noirq methods,
since at that point I always know that disable_depth > 0.
Kevin
next prev parent reply other threads:[~2011-07-11 20:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 23:41 pm_runtime_suspended() can be false if RPM_SUSPENDED Kevin Hilman
2011-07-09 10:19 ` Rafael J. Wysocki
2011-07-11 19:24 ` Kevin Hilman
2011-07-11 20:02 ` Rafael J. Wysocki
2011-07-11 20:14 ` Kevin Hilman [this message]
2011-07-11 20:22 ` Rafael J. Wysocki
2011-07-11 20:34 ` Hilman, Kevin
2011-07-11 22:36 ` Rafael J. Wysocki
2011-07-11 22:50 ` Hilman, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874o2sy3p9.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox