From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: Smartreflex on 'pm-wip/voltdm' Branch Date: Mon, 28 Mar 2011 09:27:05 -0700 Message-ID: <874o6nky7a.fsf@ti.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog115.obsmtp.com ([74.125.149.238]:49813 "EHLO na3sys009aog115.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755080Ab1C1Q1K (ORCPT ); Mon, 28 Mar 2011 12:27:10 -0400 Received: by gyf1 with SMTP id 1so1475827gyf.34 for ; Mon, 28 Mar 2011 09:27:08 -0700 (PDT) In-Reply-To: (Vishwanath Sripathy's message of "Mon, 28 Mar 2011 19:10:01 +0530") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Vishwanath Sripathy Cc: Shweta Gulati , linux-omap@vger.kernel.org Vishwa, Shweta, Vishwanath Sripathy writes: [...] >> I am testing Smartreflex on your Branch 'pm-wip/voltdm'. There seems >> an issue with reading VP registers. >> For OMAP3 and OMAP4 reading debugfs entries shows constant voltage. Thanks for testing. [...] > I did a quick debug on this and found that the root cause of the issue is > in usage of ffs (because of this, i2c slave address was configured wrongly > in vc). > Basically ffs returns the position of the first (least significant) bit > set in the word and the least significant bit is position 1 where as our > bit operation assumes that least significant position is 0. Vishwa, Thanks for findingg this. Indeed, I had assumed ffs() was zero based, but it is 1 based. > I tested the attached patch on OMAP3 and it seems to work fine. > Kevin, > You may want to incorporate this change in your next version if this seems > OK to you. Yes, I will fix this in forthcoming versions. Thanks, Kevin