Re: [PATCH V2]omap: mux.c warning removal

[Kevin Hilman <khilman@deeprootsystems.com>]

"Munegowda, Keshava" <keshava_mgowda@ti.com> writes:

> From: Keshava Munegowda <a0393220@ti.com>
>
> This patch removes the below warning 
> arch/arm/mach-omap2/mux.c:52: warning: 'mux_phys' defined but not used
> The definition of variable mux_phys should be enclosed in the macro CONFIG_ARCH_OMAP3 
>
> Signed-off-by: Keshava Munegowda <a0393220@ti.com>

Thanks, this version looks better.

Acked-by: Kevin Hilman <khilman@deeprootsystems.com>


One silly question though... is your a0....@ti.com address the one you
want as your From: and Signed-off-by?  Since the mail actually comes
from a more human readable address, I'm guessing that would be
preferred?  If so, create a ~/.gitconfig file and add this:

[user]
	name = Keshava Munegowda
	email = keshava_mgowda@ti.com

This way, all your local git commands will use this name/email in your
git commits, sign-offs etc.

Kevin







> Index: linux-2.6/arch/arm/mach-omap2/mux.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-omap2/mux.c	2010-05-05 23:59:19.000000000 +0530
> +++ linux-2.6/arch/arm/mach-omap2/mux.c	2010-05-06 00:00:07.000000000 +0530
> @@ -49,7 +49,7 @@
>  	struct list_head	node;
>  };
>  
> -static unsigned long mux_phys;
> +
>  static void __iomem *mux_base;
>  
>  u16 omap_mux_read(u16 reg)
> @@ -373,6 +373,7 @@
>  #ifdef CONFIG_ARCH_OMAP3
>  static LIST_HEAD(muxmodes);
>  static DEFINE_MUTEX(muxmode_mutex);
> +static unsigned long mux_phys;
>  
>  #ifdef CONFIG_OMAP_MUX
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html