[PM-WIP-OPP] [PATCH 1/1] OMAP3: PM: cpu-omap: Check governor limits before applying mpu frequency

[PM-WIP-OPP] [PATCH 1/1] OMAP3: PM: cpu-omap: Check governor limits before applying mpu frequency

[Eduardo Valentin]

From: Eduardo Valentin <eduardo.valentin@nokia.com>

This patch fix the sequence inside omap_target while setting
a frequency for OMAP3 devices.

Previously any frequency was set, even if out of range. Now
the range set by the governor is also checked for OMAP3.

Signed-off-by: Eduardo Valentin <eduardo.valentin@nokia.com>
---
 arch/arm/plat-omap/cpu-omap.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-omap/cpu-omap.c b/arch/arm/plat-omap/cpu-omap.c
index a69b557..0674405 100644
--- a/arch/arm/plat-omap/cpu-omap.c
+++ b/arch/arm/plat-omap/cpu-omap.c
@@ -88,7 +88,7 @@ static int omap_target(struct cpufreq_policy *policy,
 	struct cpufreq_freqs freqs;
 #endif
 #if defined(CONFIG_ARCH_OMAP3) && !defined(CONFIG_OMAP_PM_NONE)
-	unsigned long freq = target_freq * 1000;
+	unsigned long freq;
 #endif
 	int ret = 0;
 
@@ -114,6 +114,7 @@ static int omap_target(struct cpufreq_policy *policy,
 	ret = clk_set_rate(mpu_clk, freqs.new * 1000);
 	cpufreq_notify_transition(&freqs, CPUFREQ_POSTCHANGE);
 #elif defined(CONFIG_ARCH_OMAP3) && !defined(CONFIG_OMAP_PM_NONE)
+	freq = target_freq * 1000;
 	if (opp_find_freq_ceil(OPP_MPU, &freq))
 		omap_pm_cpu_set_freq(freq);
 #endif
-- 
1.7.0.2

Re: [PM-WIP-OPP] [PATCH 1/1] OMAP3: PM: cpu-omap: Check governor limits before applying mpu frequency

[Nishanth Menon]

Eduardo Valentin had written, on 03/24/2010 06:02 AM, the following:
> From: Eduardo Valentin <eduardo.valentin@nokia.com>
> 
> This patch fix the sequence inside omap_target while setting
> a frequency for OMAP3 devices.
> 
> Previously any frequency was set, even if out of range. Now
> the range set by the governor is also checked for OMAP3.
> 
> Signed-off-by: Eduardo Valentin <eduardo.valentin@nokia.com>
Good catch. thanks.

Acked-by: Nishanth Menon <nm@ti.com>

> ---
>  arch/arm/plat-omap/cpu-omap.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/cpu-omap.c b/arch/arm/plat-omap/cpu-omap.c
> index a69b557..0674405 100644
> --- a/arch/arm/plat-omap/cpu-omap.c
> +++ b/arch/arm/plat-omap/cpu-omap.c
> @@ -88,7 +88,7 @@ static int omap_target(struct cpufreq_policy *policy,
>  	struct cpufreq_freqs freqs;
>  #endif
>  #if defined(CONFIG_ARCH_OMAP3) && !defined(CONFIG_OMAP_PM_NONE)
> -	unsigned long freq = target_freq * 1000;
> +	unsigned long freq;
>  #endif
>  	int ret = 0;
>  
> @@ -114,6 +114,7 @@ static int omap_target(struct cpufreq_policy *policy,
>  	ret = clk_set_rate(mpu_clk, freqs.new * 1000);
>  	cpufreq_notify_transition(&freqs, CPUFREQ_POSTCHANGE);
>  #elif defined(CONFIG_ARCH_OMAP3) && !defined(CONFIG_OMAP_PM_NONE)
> +	freq = target_freq * 1000;
>  	if (opp_find_freq_ceil(OPP_MPU, &freq))
>  		omap_pm_cpu_set_freq(freq);
>  #endif


-- 
Regards,
Nishanth Menon

Re: [PM-WIP-OPP] [PATCH 1/1] OMAP3: PM: cpu-omap: Check governor limits before applying mpu frequency

[Kevin Hilman]

Nishanth Menon <nm@ti.com> writes:

> Eduardo Valentin had written, on 03/24/2010 06:02 AM, the following:
>> From: Eduardo Valentin <eduardo.valentin@nokia.com>
>>
>> This patch fix the sequence inside omap_target while setting
>> a frequency for OMAP3 devices.
>>
>> Previously any frequency was set, even if out of range. Now
>> the range set by the governor is also checked for OMAP3.
>>
>> Signed-off-by: Eduardo Valentin <eduardo.valentin@nokia.com>
> Good catch. thanks.
>
> Acked-by: Nishanth Menon <nm@ti.com>

Thanks, applying to pm-wip-opp (which I'm still trying to find the time to
rebase for upstream)

Kevin