[PATCH 0/6] Regulator: Removing common code for TWL4030 PMIC from various OMAP3 board-evms

[PATCH 0/6] Regulator: Removing common code for TWL4030 PMIC from various OMAP3 board-evms

[Anuj Aggarwal]

Based on the discussions and feedback received, this patch set is
created which cleans up various OMAP3-board-evm files and removes
common TWL4030 specific regulator suuplies and init data structs.
These structures are instead placed in a new file - 
board-omap35x-twl4030-pmic.c and are referenced from the board-evm
files depending on the platform requirements. Regulator having specific
supplies or init data structs are not changed in their respective
board-evms.

The main advantages of having one common file for these structures
are redundant code removal, easy maintainability and single copy of 
common structure(s) in case uImage for multiple platforms is built.

Please see the following links for previous discussions:
  http://marc.info/?l=linux-omap&m=125795487111175&w=2
  http://marc.info/?l=linux-omap&m=125795068502904&w=2 

I have tested these patches on OMAP3EVM and the image boots fine. I
have compile-tested them for SDP3430 and all OMAP platforms (using
omap3_defconfig) and the build went fine. If someone can test them
on their hardware, that would be great !!!

Anuj Aggarwal (6):
  Regulator: Creating TWL4030 specific file having supplies & init data
  Regulator: Removing the common supplies and regulator init data
    structs
  Regulator: Use common regulator supplies and init data structs
  Regulator: Modifying Kconfig to choose from the available PMICs
  Regulator: Kconfig modified to select TWL4030 for OMAP3 based
    platforms
  Regulator: Makefile modified to include TWL4030-PMIC specific file

 arch/arm/mach-omap2/Kconfig                      |   20 +++
 arch/arm/mach-omap2/Makefile                     |    1 +
 arch/arm/mach-omap2/board-3430sdp.c              |  146 +++---------------
 arch/arm/mach-omap2/board-cm-t35.c               |   52 ++-----
 arch/arm/mach-omap2/board-igep0020.c             |   26 +---
 arch/arm/mach-omap2/board-ldp.c                  |   26 +---
 arch/arm/mach-omap2/board-omap35x-twl4030-pmic.c |  175 ++++++++++++++++++++++
 arch/arm/mach-omap2/board-omap3beagle.c          |   52 ++-----
 arch/arm/mach-omap2/board-omap3evm.c             |   63 ++------
 arch/arm/mach-omap2/board-omap3pandora.c         |   52 ++-----
 arch/arm/mach-omap2/board-omap3touchbook.c       |   52 ++-----
 arch/arm/mach-omap2/board-overo.c                |   26 +---
 arch/arm/mach-omap2/board-zoom-peripherals.c     |   78 ++--------
 13 files changed, 304 insertions(+), 465 deletions(-)
 create mode 100644 arch/arm/mach-omap2/board-omap35x-twl4030-pmic.c

Re: [PATCH 0/6] Regulator: Removing common code for TWL4030 PMIC from various OMAP3 board-evms

[Kevin Hilman]

Anuj Aggarwal <anuj.aggarwal@ti.com> writes:

> Based on the discussions and feedback received, this patch set is
> created which cleans up various OMAP3-board-evm files and removes
> common TWL4030 specific regulator suuplies and init data structs.
> These structures are instead placed in a new file - 
> board-omap35x-twl4030-pmic.c and are referenced from the board-evm

Why is this omap35x?  You seem to be using this from omap34xx board
files as well.

I don't think you need the board-omap* prefix at all.  Why not just
call it twl4030-pmic.c.

There has been some proposals to unify the twl4030 scripts as well by
Lesley, and this new file would be a logical place for those as well.

Kevin


> files depending on the platform requirements. Regulator having specific
> supplies or init data structs are not changed in their respective
> board-evms.
>
> The main advantages of having one common file for these structures
> are redundant code removal, easy maintainability and single copy of 
> common structure(s) in case uImage for multiple platforms is built.
>
> Please see the following links for previous discussions:
>   http://marc.info/?l=linux-omap&m=125795487111175&w=2
>   http://marc.info/?l=linux-omap&m=125795068502904&w=2 
>
> I have tested these patches on OMAP3EVM and the image boots fine. I
> have compile-tested them for SDP3430 and all OMAP platforms (using
> omap3_defconfig) and the build went fine. If someone can test them
> on their hardware, that would be great !!!
>
> Anuj Aggarwal (6):
>   Regulator: Creating TWL4030 specific file having supplies & init data
>   Regulator: Removing the common supplies and regulator init data
>     structs
>   Regulator: Use common regulator supplies and init data structs
>   Regulator: Modifying Kconfig to choose from the available PMICs
>   Regulator: Kconfig modified to select TWL4030 for OMAP3 based
>     platforms
>   Regulator: Makefile modified to include TWL4030-PMIC specific file
>
>  arch/arm/mach-omap2/Kconfig                      |   20 +++
>  arch/arm/mach-omap2/Makefile                     |    1 +
>  arch/arm/mach-omap2/board-3430sdp.c              |  146 +++---------------
>  arch/arm/mach-omap2/board-cm-t35.c               |   52 ++-----
>  arch/arm/mach-omap2/board-igep0020.c             |   26 +---
>  arch/arm/mach-omap2/board-ldp.c                  |   26 +---
>  arch/arm/mach-omap2/board-omap35x-twl4030-pmic.c |  175 ++++++++++++++++++++++
>  arch/arm/mach-omap2/board-omap3beagle.c          |   52 ++-----
>  arch/arm/mach-omap2/board-omap3evm.c             |   63 ++------
>  arch/arm/mach-omap2/board-omap3pandora.c         |   52 ++-----
>  arch/arm/mach-omap2/board-omap3touchbook.c       |   52 ++-----
>  arch/arm/mach-omap2/board-overo.c                |   26 +---
>  arch/arm/mach-omap2/board-zoom-peripherals.c     |   78 ++--------
>  13 files changed, 304 insertions(+), 465 deletions(-)
>  create mode 100644 arch/arm/mach-omap2/board-omap35x-twl4030-pmic.c
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 0/6] Regulator: Removing common code for TWL4030 PMIC from various OMAP3 board-evms

[Aggarwal, Anuj]

> -----Original Message-----
> From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
> Sent: Saturday, January 09, 2010 3:57 AM
> To: Aggarwal, Anuj
> Cc: linux-omap@vger.kernel.org; broonie@opensource.wolfsonmicro.com;
> lrg@slimlogic.co.uk
> Subject: Re: [PATCH 0/6] Regulator: Removing common code for TWL4030 PMIC
> from various OMAP3 board-evms
> 
> Anuj Aggarwal <anuj.aggarwal@ti.com> writes:
> 
> > Based on the discussions and feedback received, this patch set is
> > created which cleans up various OMAP3-board-evm files and removes
> > common TWL4030 specific regulator suuplies and init data structs.
> > These structures are instead placed in a new file -
> > board-omap35x-twl4030-pmic.c and are referenced from the board-evm
> 
> Why is this omap35x?  You seem to be using this from omap34xx board
> files as well.
> 
> I don't think you need the board-omap* prefix at all.  Why not just
> call it twl4030-pmic.c.
> 
[Aggarwal, Anuj] That's fine with me. I will wait for some more comments 
to pour in today and will re-send the patch with this modification.

> There has been some proposals to unify the twl4030 scripts as well by
> Lesley, and this new file would be a logical place for those as well.
> 
> Kevin
> 
> 
> > files depending on the platform requirements. Regulator having specific
> > supplies or init data structs are not changed in their respective
> > board-evms.
> >
> > The main advantages of having one common file for these structures
> > are redundant code removal, easy maintainability and single copy of
> > common structure(s) in case uImage for multiple platforms is built.
> >
> > Please see the following links for previous discussions:
> >   http://marc.info/?l=linux-omap&m=125795487111175&w=2
> >   http://marc.info/?l=linux-omap&m=125795068502904&w=2
> >
> > I have tested these patches on OMAP3EVM and the image boots fine. I
> > have compile-tested them for SDP3430 and all OMAP platforms (using
> > omap3_defconfig) and the build went fine. If someone can test them
> > on their hardware, that would be great !!!
> >
> > Anuj Aggarwal (6):
> >   Regulator: Creating TWL4030 specific file having supplies & init data
> >   Regulator: Removing the common supplies and regulator init data
> >     structs
> >   Regulator: Use common regulator supplies and init data structs
> >   Regulator: Modifying Kconfig to choose from the available PMICs
> >   Regulator: Kconfig modified to select TWL4030 for OMAP3 based
> >     platforms
> >   Regulator: Makefile modified to include TWL4030-PMIC specific file
> >
> >  arch/arm/mach-omap2/Kconfig                      |   20 +++
> >  arch/arm/mach-omap2/Makefile                     |    1 +
> >  arch/arm/mach-omap2/board-3430sdp.c              |  146 +++------------
> ---
> >  arch/arm/mach-omap2/board-cm-t35.c               |   52 ++-----
> >  arch/arm/mach-omap2/board-igep0020.c             |   26 +---
> >  arch/arm/mach-omap2/board-ldp.c                  |   26 +---
> >  arch/arm/mach-omap2/board-omap35x-twl4030-pmic.c |  175
> ++++++++++++++++++++++
> >  arch/arm/mach-omap2/board-omap3beagle.c          |   52 ++-----
> >  arch/arm/mach-omap2/board-omap3evm.c             |   63 ++------
> >  arch/arm/mach-omap2/board-omap3pandora.c         |   52 ++-----
> >  arch/arm/mach-omap2/board-omap3touchbook.c       |   52 ++-----
> >  arch/arm/mach-omap2/board-overo.c                |   26 +---
> >  arch/arm/mach-omap2/board-zoom-peripherals.c     |   78 ++--------
> >  13 files changed, 304 insertions(+), 465 deletions(-)
> >  create mode 100644 arch/arm/mach-omap2/board-omap35x-twl4030-pmic.c
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/6] Regulator: Removing common code for TWL4030 PMIC from various OMAP3 board-evms

[Mark Brown]

On Fri, Jan 08, 2010 at 11:27:28PM +0530, Anuj Aggarwal wrote:
> Based on the discussions and feedback received, this patch set is
> created which cleans up various OMAP3-board-evm files and removes
> common TWL4030 specific regulator suuplies and init data structs.

Please use an OMAP-specific subject line for this patch series - there's
no generic regulator changes in here, it's all OMAP-specific.  This
helps with scanning inboxes and mailing list folders.