Re: [PATCH] MUSB: Remove usb_musb_pm_init() call

[Kevin Hilman <khilman@deeprootsystems.com>]

"Gadiyar, Anand" <gadiyar@ti.com> writes:

>> > MUSB: Remove usb_musb_pm_init() call
>> >
>> > In usb_musb_pm_init, we attempt to access an MUSB register
>> > when the i-clock may not be on, or the module is otherwise
>> > not accessible.
>> >
>> > We need to either:
>> > - enable the clock before this access, or
>> > - remove this code and move it to the bootloader, or
>> > - enable the clock in the bootloader
>> >
>> > If we enable the clock in the bootloader, we might as well
>> > add the workaround in the bootloader itself. This code will
>> > anyway be changed once hwmod is in place, so remove it for now
>> >
>> > This allows us to boot the kernel on certain OMAP3 boards with
>> > a bootloader that doesn't enable this clock. Without this, we
>> > will need to upgrade the bootloaders on these boards.
>> >
>> > Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
>> 
>> NAK.
>> 
>> The PM branch already has a fix from Jon Hunter[1] for this which enables
>> the clock, and in the thread where we discussed this I mentioned I would
>> carry it in the PM branch until the hwmod for OTG is ready.
>
> Right, but at least merge this into master and mainline for now,
> so that boards that used to boot up okay before can continue to do so now.
>
> Not everybody is working on the pm branch.

ok, I understand now.  Was thinking you meant this for the PM branch.
Sorry for the confusion.

I'll pull this into my fixes queue for the next merge window.

Thanks,

Kevin