From: Kevin Hilman <khilman@ti.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-omap@vger.kernel.org, tony@atomide.com,
toddpoynor@google.com, broonie@opensource.wolfsonmicro.com,
lrg@ti.com
Subject: Re: [PATCHv3 1/6] OMAP: move voltage.h and vp.h under platform include directory
Date: Mon, 18 Jul 2011 16:45:27 -0700 [thread overview]
Message-ID: <8762mzkvag.fsf@ti.com> (raw)
In-Reply-To: <1311010522-5868-2-git-send-email-t-kristo@ti.com> (Tero Kristo's message of "Mon, 18 Jul 2011 20:35:17 +0300")
Tero Kristo <t-kristo@ti.com> writes:
> This is needed so that these include files can be accessed from drivers.
I think you can get by with a <plat/voltage.h> with simply an opaque
struct voltagedomain, and the definitions of the functions needed by the
regulator driver (currently only voltdm_scale, omap_vp_get_curr_volt).
Then mach-omap2/voltage.h could just include <plat/voltage.h> and all
the truly internal stuff can stay internal.
Also note that in the latest pm-wip/voltdm branch (just pushed)
omap_vp_get_curr_volt() no longer exists. Just use
voltdm_get_voltage().
Kevin
next prev parent reply other threads:[~2011-07-18 23:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 17:35 [PATCHv3 0/6] OMAP SMPS regulator driver Tero Kristo
2011-07-18 17:35 ` [PATCHv3 1/6] OMAP: move voltage.h and vp.h under platform include directory Tero Kristo
2011-07-18 18:16 ` Felipe Balbi
2011-07-19 7:49 ` Tero Kristo
2011-07-18 23:45 ` Kevin Hilman [this message]
2011-07-18 17:35 ` [PATCHv3 2/6] omap: voltage: change code to use new location of voltage.h and vp.h Tero Kristo
2011-07-18 18:16 ` Felipe Balbi
2011-07-19 7:47 ` Tero Kristo
2011-07-18 17:35 ` [PATCHv3 3/6] regulator: omap smps regulator driver Tero Kristo
2011-07-18 18:22 ` Felipe Balbi
2011-07-18 23:40 ` Kevin Hilman
2011-07-19 7:53 ` Tero Kristo
2011-07-19 7:58 ` Tero Kristo
2011-07-19 10:28 ` Graeme Gregory
2011-07-19 15:38 ` Mark Brown
2011-07-19 15:52 ` Tero Kristo
2011-07-18 17:35 ` [PATCHv3 4/6] omap3: pmic: add API to get common SMPS regulators Tero Kristo
2011-07-18 18:23 ` Felipe Balbi
2011-07-19 8:07 ` Tero Kristo
2011-07-18 17:35 ` [PATCHv3 5/6] omap3: beagleboard: add " Tero Kristo
2011-07-18 17:35 ` [PATCHv3 6/6] TEMP: OMAP3: beagle rev-c4: enable OPP6 Tero Kristo
2011-07-18 17:55 ` [PATCHv3 0/6] OMAP SMPS regulator driver Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762mzkvag.fsf@ti.com \
--to=khilman@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=t-kristo@ti.com \
--cc=toddpoynor@google.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox