Re: [PM-WIP-OPP][PATCH] OMAP3 PM: Fix issue with opp_find_freq_floor

[Kevin Hilman <khilman@deeprootsystems.com>]

Nishanth Menon <nm@ti.com> writes:

> Sripathy, Vishwanath had written, on 04/06/2010 12:56 PM, the following:
>> opp_find_freq_floor should return the lower "enabled* OPP from a starting freq
>> from a start opp list. But current code returns next lower opp. This patch fixes
>> this issue.
>>
>> Signed-off-by: Vishwanath BS <vishwanath.bs@ti.com>
>> ---
>> diff --git a/arch/arm/plat-omap/opp.c b/arch/arm/plat-omap/opp.c
>> index bb8120e..13da451
>> --- a/arch/arm/plat-omap/opp.c
>> +++ b/arch/arm/plat-omap/opp.c
>> @@ -208,7 +208,7 @@ struct omap_opp *opp_find_freq_floor(enum opp_t opp_type, unsigned long *freq)
>>   	*freq = prev_opp->rate;
>>  -	return oppl;
>> +	return prev_opp;
>>  }
>>  
> Thanks. yep. since we return *freq with the right rate, we should
> point also to the right opp.
>
> Acked-by: Nishanth Menon <nm@ti.com>

Thanks, pushed to pm-wip-opp

Kevin