public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Nayak, Rajendra" <rnayak@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 00/05] OMAP3: SR: Fixes in Smartreflex driver
Date: Wed, 18 Mar 2009 09:29:19 -0700	[thread overview]
Message-ID: <8763i6pzfk.fsf@deeprootsystems.com> (raw)
In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB02FAEDE846@dbde02.ent.ti.com> (Rajendra Nayak's message of "Wed\, 18 Mar 2009 15\:25\:10 +0530")

"Nayak, Rajendra" <rnayak@ti.com> writes:

> Hi,
>
> This series fixes a set of defects/issues in Smartreflex driver. SR autocompensation is now
> functional and is validated with these patches on a ES3.1 based SDP with the
> N values in Efuse.
> Patches apply and are validated on the latest pm branch (2.6.28).
>

Hi Rajendra,

Thanks for this series of SR fixes.  I send a couple very minor
comments to a couple of the patches.  Also, this series does not apply
cleanly to pm-2.6.28, I'm not sure why.  Applying manually with
'patch' allows them to apply with "fuzz" suggesting that they were not
generated against the current tree.

Also, while you are in there cleaing up, could you add one more patch
which converts the printk(KERN_* ...) into pr_debug, pr_err, pr_info,
etc.

Thanks,

Kevin


  reply	other threads:[~2009-03-18 16:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-18  9:55 [PATCH 00/05] OMAP3: SR: Fixes in Smartreflex driver Nayak, Rajendra
2009-03-18 16:29 ` Kevin Hilman [this message]
2009-03-19  9:57   ` Nayak, Rajendra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8763i6pzfk.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=rnayak@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox