From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Loïc Minier" <loic.minier@linaro.org>
Cc: linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
Thara Gopinath <thara@ti.com>
Subject: Re: [PATCH] OMAP: PM: Fix build when CONFIG_PM_DEBUG isn't set
Date: Fri, 01 Oct 2010 13:19:07 -0700 [thread overview]
Message-ID: <877hi18y4k.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1285621460-22011-1-git-send-email-loic.minier@linaro.org> ("Loïc Minier"'s message of "Mon, 27 Sep 2010 23:04:20 +0200")
Loïc Minier <loic.minier@linaro.org> writes:
> Since 6cdee91257bee23a46dc869ca62469b67cba2c7e the references to
> enable_off_mode and sleep_while_idle can't be resolved when CONFIG_PM_DEBUG
> isn't set:
> arch/arm/mach-omap2/built-in.o: In function `omap_uart_restore_context':
> arch/arm/mach-omap2/serial.c:253: undefined reference to `enable_off_mode'
> arch/arm/mach-omap2/built-in.o: In function `omap3_can_sleep':
> arch/arm/mach-omap2/pm34xx.c:479: undefined reference to `sleep_while_idle'
>
> Simply #define these in pm.h just like omap2_pm_debug.
>
> Signed-off-by: Loïc Minier <loic.minier@linaro.org>
Applying this fix, but moving the change down into an existing #ifdef
Kevin
> ---
> arch/arm/mach-omap2/pm.h | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
> index 77770a1..68db3a7 100644
> --- a/arch/arm/mach-omap2/pm.h
> +++ b/arch/arm/mach-omap2/pm.h
> @@ -13,8 +13,13 @@
>
> #include <plat/powerdomain.h>
>
> +#ifdef CONFIG_PM_DEBUG
> extern u32 enable_off_mode;
> extern u32 sleep_while_idle;
> +#else
> +#define enable_off_mode 0
> +#define sleep_while_idle 0
> +#endif
>
> extern void *omap3_secure_ram_storage;
> extern void omap3_pm_off_mode_enable(int);
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-10-01 20:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-25 13:36 [PATCH] OMAP: PM: Fix build when CONFIG_PM_DEBUG isn't set Loïc Minier
2010-09-27 19:50 ` Kevin Hilman
2010-09-27 21:04 ` Loïc Minier
2010-10-01 20:19 ` Kevin Hilman [this message]
2010-09-27 21:05 ` Loïc Minier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877hi18y4k.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=loic.minier@linaro.org \
--cc=thara@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).