* [PATCH] OMAP: PM: Fix build when CONFIG_PM_DEBUG isn't set
@ 2010-09-25 13:36 Loïc Minier
2010-09-27 19:50 ` Kevin Hilman
0 siblings, 1 reply; 5+ messages in thread
From: Loïc Minier @ 2010-09-25 13:36 UTC (permalink / raw)
To: linux-omap; +Cc: Tony Lindgren, Thara Gopinath, Kevin Hilman, Loïc Minier
Since 6cdee91257bee23a46dc869ca62469b67cba2c7e the references to
enable_off_mode and sleep_while_idle can't be resolved when CONFIG_PM_DEBUG
isn't set:
arch/arm/mach-omap2/built-in.o: In function `omap_uart_restore_context':
arch/arm/mach-omap2/serial.c:253: undefined reference to `enable_off_mode'
arch/arm/mach-omap2/built-in.o: In function `omap3_can_sleep':
arch/arm/mach-omap2/pm34xx.c:479: undefined reference to `sleep_while_idle'
Simply #define these in pm.h just like omap2_pm_debug.
---
arch/arm/mach-omap2/pm.h | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
index 77770a1..68db3a7 100644
--- a/arch/arm/mach-omap2/pm.h
+++ b/arch/arm/mach-omap2/pm.h
@@ -13,8 +13,13 @@
#include <plat/powerdomain.h>
+#ifdef CONFIG_PM_DEBUG
extern u32 enable_off_mode;
extern u32 sleep_while_idle;
+#else
+#define enable_off_mode 0
+#define sleep_while_idle 0
+#endif
extern void *omap3_secure_ram_storage;
extern void omap3_pm_off_mode_enable(int);
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP: PM: Fix build when CONFIG_PM_DEBUG isn't set
2010-09-25 13:36 [PATCH] OMAP: PM: Fix build when CONFIG_PM_DEBUG isn't set Loïc Minier
@ 2010-09-27 19:50 ` Kevin Hilman
2010-09-27 21:04 ` Loïc Minier
2010-09-27 21:05 ` Loïc Minier
0 siblings, 2 replies; 5+ messages in thread
From: Kevin Hilman @ 2010-09-27 19:50 UTC (permalink / raw)
To: Loïc Minier; +Cc: linux-omap, Tony Lindgren, Thara Gopinath
Hi Loïc,
Loïc Minier <loic.minier@linaro.org> writes:
> Since 6cdee91257bee23a46dc869ca62469b67cba2c7e the references to
> enable_off_mode and sleep_while_idle can't be resolved when CONFIG_PM_DEBUG
> isn't set:
> arch/arm/mach-omap2/built-in.o: In function `omap_uart_restore_context':
> arch/arm/mach-omap2/serial.c:253: undefined reference to `enable_off_mode'
> arch/arm/mach-omap2/built-in.o: In function `omap3_can_sleep':
> arch/arm/mach-omap2/pm34xx.c:479: undefined reference to `sleep_while_idle'
>
> Simply #define these in pm.h just like omap2_pm_debug.
Could you move these down into the exisint #ifdef CONFIG_PM_DEBUG a
little bit later in the file (after where omap2_pm_debug.)
Also, could you sign-off on the patch please?
Thanks,
Kevin
> ---
> arch/arm/mach-omap2/pm.h | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
> index 77770a1..68db3a7 100644
> --- a/arch/arm/mach-omap2/pm.h
> +++ b/arch/arm/mach-omap2/pm.h
> @@ -13,8 +13,13 @@
>
> #include <plat/powerdomain.h>
>
> +#ifdef CONFIG_PM_DEBUG
> extern u32 enable_off_mode;
> extern u32 sleep_while_idle;
> +#else
> +#define enable_off_mode 0
> +#define sleep_while_idle 0
> +#endif
>
> extern void *omap3_secure_ram_storage;
> extern void omap3_pm_off_mode_enable(int);
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] OMAP: PM: Fix build when CONFIG_PM_DEBUG isn't set
2010-09-27 19:50 ` Kevin Hilman
@ 2010-09-27 21:04 ` Loïc Minier
2010-10-01 20:19 ` Kevin Hilman
2010-09-27 21:05 ` Loïc Minier
1 sibling, 1 reply; 5+ messages in thread
From: Loïc Minier @ 2010-09-27 21:04 UTC (permalink / raw)
To: linux-omap; +Cc: Tony Lindgren, Thara Gopinath, Kevin Hilman, Loïc Minier
Since 6cdee91257bee23a46dc869ca62469b67cba2c7e the references to
enable_off_mode and sleep_while_idle can't be resolved when CONFIG_PM_DEBUG
isn't set:
arch/arm/mach-omap2/built-in.o: In function `omap_uart_restore_context':
arch/arm/mach-omap2/serial.c:253: undefined reference to `enable_off_mode'
arch/arm/mach-omap2/built-in.o: In function `omap3_can_sleep':
arch/arm/mach-omap2/pm34xx.c:479: undefined reference to `sleep_while_idle'
Simply #define these in pm.h just like omap2_pm_debug.
Signed-off-by: Loïc Minier <loic.minier@linaro.org>
---
arch/arm/mach-omap2/pm.h | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
index 77770a1..68db3a7 100644
--- a/arch/arm/mach-omap2/pm.h
+++ b/arch/arm/mach-omap2/pm.h
@@ -13,8 +13,13 @@
#include <plat/powerdomain.h>
+#ifdef CONFIG_PM_DEBUG
extern u32 enable_off_mode;
extern u32 sleep_while_idle;
+#else
+#define enable_off_mode 0
+#define sleep_while_idle 0
+#endif
extern void *omap3_secure_ram_storage;
extern void omap3_pm_off_mode_enable(int);
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP: PM: Fix build when CONFIG_PM_DEBUG isn't set
2010-09-27 21:04 ` Loïc Minier
@ 2010-10-01 20:19 ` Kevin Hilman
0 siblings, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2010-10-01 20:19 UTC (permalink / raw)
To: Loïc Minier; +Cc: linux-omap, Tony Lindgren, Thara Gopinath
Loïc Minier <loic.minier@linaro.org> writes:
> Since 6cdee91257bee23a46dc869ca62469b67cba2c7e the references to
> enable_off_mode and sleep_while_idle can't be resolved when CONFIG_PM_DEBUG
> isn't set:
> arch/arm/mach-omap2/built-in.o: In function `omap_uart_restore_context':
> arch/arm/mach-omap2/serial.c:253: undefined reference to `enable_off_mode'
> arch/arm/mach-omap2/built-in.o: In function `omap3_can_sleep':
> arch/arm/mach-omap2/pm34xx.c:479: undefined reference to `sleep_while_idle'
>
> Simply #define these in pm.h just like omap2_pm_debug.
>
> Signed-off-by: Loïc Minier <loic.minier@linaro.org>
Applying this fix, but moving the change down into an existing #ifdef
Kevin
> ---
> arch/arm/mach-omap2/pm.h | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
> index 77770a1..68db3a7 100644
> --- a/arch/arm/mach-omap2/pm.h
> +++ b/arch/arm/mach-omap2/pm.h
> @@ -13,8 +13,13 @@
>
> #include <plat/powerdomain.h>
>
> +#ifdef CONFIG_PM_DEBUG
> extern u32 enable_off_mode;
> extern u32 sleep_while_idle;
> +#else
> +#define enable_off_mode 0
> +#define sleep_while_idle 0
> +#endif
>
> extern void *omap3_secure_ram_storage;
> extern void omap3_pm_off_mode_enable(int);
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] OMAP: PM: Fix build when CONFIG_PM_DEBUG isn't set
2010-09-27 19:50 ` Kevin Hilman
2010-09-27 21:04 ` Loïc Minier
@ 2010-09-27 21:05 ` Loïc Minier
1 sibling, 0 replies; 5+ messages in thread
From: Loïc Minier @ 2010-09-27 21:05 UTC (permalink / raw)
To: Kevin Hilman; +Cc: linux-omap, Tony Lindgren, Thara Gopinath
On Mon, Sep 27, 2010, Kevin Hilman wrote:
> Could you move these down into the exisint #ifdef CONFIG_PM_DEBUG a
> little bit later in the file (after where omap2_pm_debug.)
I hesitated doing that since there were a couple of other ifdefs using
CONFIG_PM_DEBUG later in the file; I will send an updated patch moving
to the ifdef CONFIG_PM_DEBUG.
> Also, could you sign-off on the patch please?
Ah sorry about that
--
Loïc Minier
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-10-01 20:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-25 13:36 [PATCH] OMAP: PM: Fix build when CONFIG_PM_DEBUG isn't set Loïc Minier
2010-09-27 19:50 ` Kevin Hilman
2010-09-27 21:04 ` Loïc Minier
2010-10-01 20:19 ` Kevin Hilman
2010-09-27 21:05 ` Loïc Minier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).