From: Kevin Hilman <khilman@linaro.org>
To: Andreas Fenkart <andreas.fenkart@streamunlimited.com>
Cc: santosh.shilimkar@ti.com, grant.likely@secretlab.ca,
linus.walleij@linaro.org, balbi@ti.com,
linux-omap@vger.kernel.org, daniel@zonque.org, jon-hunter@ti.com
Subject: Re: [PATCH v3] gpio/omap: implement irq mask/disable with proper semantic.
Date: Tue, 23 Apr 2013 16:38:38 -0700 [thread overview]
Message-ID: <878v486cn5.fsf@linaro.org> (raw)
In-Reply-To: <1366620861-5489-2-git-send-email-andreas.fenkart@streamunlimited.com> (Andreas Fenkart's message of "Mon, 22 Apr 2013 10:54:21 +0200")
Andreas Fenkart <andreas.fenkart@streamunlimited.com> writes:
> When a gpio interrupt is masked, the gpio event will still be latched in
> the interrupt status register so when you unmask it later you may get an
> interrupt straight away. However, if the interrupt is disabled then gpio
> events occurring will not be latched/stored.
>
> Signed-off-by: Andreas Fenkart <andreas.fenkart@streamunlimited.com>
The approach seems OK to me, but the changelog is still missing quite a
bit of information.
I know it's been hashed over in the various threads, but the changelog
needs all that discussion summarized. The changelog should at least:
- describe the problem/bug being fixed
- describe the fix
- answer "why" the approach was taken (not how.) This part is very
important to reviewers and maintainers.
- how it was tested, and on what platforms
In addition, I'd like to see a description of how (or whether) this
affects the genirq lazy disable functionality, and how it was tested.
Kevin
next prev parent reply other threads:[~2013-04-23 23:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 9:13 [PATCH v2] gpio/omap: implement irq_enable/disable using mask/unmask Andreas Fenkart
2013-04-12 9:13 ` [PATCH] " Andreas Fenkart
2013-04-12 10:19 ` Santosh Shilimkar
2013-04-12 11:07 ` Felipe Balbi
2013-04-19 19:25 ` Andreas Fenkart
2013-04-19 19:20 ` [PATCH v2] gpio/omap: implement irq mask/disable with proper semantic Andreas Fenkart
2013-04-20 12:35 ` Santosh Shilimkar
2013-04-22 8:54 ` [PATCH v3] gpio/omap: implement irq mask/disable with proper Andreas Fenkart
2013-04-22 8:54 ` [PATCH v3] gpio/omap: implement irq mask/disable with proper semantic Andreas Fenkart
2013-04-23 23:38 ` Kevin Hilman [this message]
2013-04-25 19:30 ` Jon Hunter
2013-04-25 19:40 ` Jon Hunter
2013-04-26 15:46 ` Jon Hunter
2013-04-26 7:56 ` [PATCH v2] " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878v486cn5.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=andreas.fenkart@streamunlimited.com \
--cc=balbi@ti.com \
--cc=daniel@zonque.org \
--cc=grant.likely@secretlab.ca \
--cc=jon-hunter@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).