From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 2/2] ARM: OMAP4: Register the OPP table only for 4430 device Date: Thu, 09 Aug 2012 08:01:13 -0700 Message-ID: <878vdogldy.fsf@ti.com> References: <1344423254-3475-1-git-send-email-rnayak@ti.com> <1344423254-3475-3-git-send-email-rnayak@ti.com> <87628twbd3.fsf@ti.com> <50236570.6030301@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <50236570.6030301@ti.com> (Rajendra Nayak's message of "Thu, 09 Aug 2012 12:53:28 +0530") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Rajendra Nayak Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org Rajendra Nayak writes: > Hi Kevin, > > On Wednesday 08 August 2012 10:48 PM, Kevin Hilman wrote: >>> The 4430 OPP table was being registered for all other OMAP4 variants >>> > too, like 4460 and 4470 causing issues with cpufreq driver >>> > enabled. 4460 and 4470 devices have different OPPs as compared to >>> > 4430, and they should be populated seperately. As long as that >>> > happens, let the OPP table registeration happen only on 4430 device. >>> > >>> > Signed-off-by: Rajendra Nayak >> Thanks, adding to PM fixes for v3.6-rc (branch: for_3.6/fixes/pm) > > I just posted a v2 of this series addressing the issues raised by > Santosh on Patch 1/2. The problem with taking just $subject fix (or > taking it before Patch 1/2) is that you would hit the issue fixed > by the Patch 1/2 and cause a crash on non-4430 based OMAP4 devices with > cpufreq enabled. OK, thanks for the warning. I'll be sure to keep them together. Kevin