From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH 1/2] ARM: OMAP3: PM: remove superfluous calls to pwrdm_clear_all_prev_pwrst() Date: Thu, 02 Feb 2012 10:14:53 -0800 Message-ID: <878vkldrvm.fsf@ti.com> References: <20120130093931.11027.31048.stgit@dusk> <20120130094312.11027.31050.stgit@dusk> <878vkopw2o.fsf@ti.com> <87mx93ok5y.fsf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog113.obsmtp.com ([74.125.149.209]:52463 "EHLO na3sys009aog113.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932914Ab2BBSOw (ORCPT ); Thu, 2 Feb 2012 13:14:52 -0500 Received: by mail-pw0-f54.google.com with SMTP id v10so2674620pbd.41 for ; Thu, 02 Feb 2012 10:14:51 -0800 (PST) In-Reply-To: (Paul Walmsley's message of "Wed, 1 Feb 2012 12:27:14 -0700 (MST)") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: Rajendra Nayak , Santosh Shilimkar , Tero Kristo , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Paul Walmsley writes: > On Tue, 31 Jan 2012, Kevin Hilman wrote: > >> Kevin Hilman writes: >> >> > Paul Walmsley writes: >> > >> >> Remove some superfluous calls to pwrdm_clear_all_prev_pwrst(). >> >> pwrdm_pre_transition(), which appears a few lines after these calls, >> >> invokes pwrdm_clear_all_prev_pwrst() on each powerdomain -- there's no >> >> need to do it twice. >> > >> > It looks like these two for OMAP4 are surpurfluous since the immediately >> > follow a call to pwrdm_pre_transition() as well. >> > >> > Santosh/Rajendra, please confirm/ack. >> >> So after the discussion, do you want to fold this into the original >> patch, or do you want a separate patch? > > Your changes make sense to me. I am fine with you adding them into the > original patch and adding some credit for you into the commit message. > Or you can create a separate patch. OK, I'll fold it in. Thanks, Kevin