From: Kevin Hilman <khilman@deeprootsystems.com>
To: Ben Dooks <ben-i2c@fluff.org>
Cc: paul@pwsan.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Rajendra Nayak <rnayak@ti.com>, Benoit Cousson <b-cousson@ti.com>
Subject: Re: [PATCH v2 1/2] I2C: i2c-omap: Change device name: i2c_omap -> omap_i2c
Date: Thu, 09 Dec 2010 08:55:28 -0800 [thread overview]
Message-ID: <878vzydgxr.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1291904657-32729-2-git-send-email-b-cousson@ti.com> (Benoit Cousson's message of "Thu, 9 Dec 2010 15:24:16 +0100")
Ben,
Benoit Cousson <b-cousson@ti.com> writes:
> The convention for omap device naming is omap_XXX.
>
> Rename the device and driver name in order to stick
> to this naming convention.
>
> Change device name in clock nodes as well.
>
> Signed-off-by: Benoit Cousson <b-cousson@ti.com>
> c: Paul Walmsley <paul@pwsan.com>
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
> Cc: Rajendra Nayak <rnayak@ti.com>
> Cc: Ben Dooks <ben-i2c@fluff.org>
> ---
> arch/arm/mach-omap1/clock_data.c | 6 +++---
> arch/arm/mach-omap2/clock2420_data.c | 8 ++++----
> arch/arm/mach-omap2/clock2430_data.c | 8 ++++----
> arch/arm/mach-omap2/clock3xxx_data.c | 12 ++++++------
> arch/arm/mach-omap2/clock44xx_data.c | 16 ++++++++--------
> arch/arm/plat-omap/i2c.c | 2 +-
> drivers/i2c/busses/i2c-omap.c | 4 ++--
> 7 files changed, 28 insertions(+), 28 deletions(-)
[...]
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 760b8be..9d09083 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -1139,7 +1139,7 @@ static struct platform_driver omap_i2c_driver = {
> .probe = omap_i2c_probe,
> .remove = omap_i2c_remove,
> .driver = {
> - .name = "i2c_omap",
> + .name = "omap_i2c",
> .owner = THIS_MODULE,
> },
> };
> @@ -1161,4 +1161,4 @@ module_exit(omap_i2c_exit_driver);
> MODULE_AUTHOR("MontaVista Software, Inc. (and others)");
> MODULE_DESCRIPTION("TI OMAP I2C bus adapter");
> MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:i2c_omap");
> +MODULE_ALIAS("platform:omap_i2c");
With your ack for the name change in the driver, we can merge this
through the OMAP tree with the other core changes.
Thanks,
Kevin
next prev parent reply other threads:[~2010-12-09 16:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 14:24 [PATCH v2 0/2] OMAP: I2C and UART device name cleanup Benoit Cousson
2010-12-09 14:24 ` [PATCH v2 1/2] I2C: i2c-omap: Change device name: i2c_omap -> omap_i2c Benoit Cousson
2010-12-09 16:55 ` Kevin Hilman [this message]
2010-12-09 19:01 ` Ben Dooks
2010-12-09 20:46 ` Kevin Hilman
2010-12-09 22:18 ` aaro.koskinen
2010-12-09 22:21 ` Ben Dooks
2010-12-09 23:39 ` Ben Dooks
2010-12-10 8:28 ` Cousson, Benoit
2010-12-18 1:55 ` Tony Lindgren
2010-12-20 16:07 ` Kevin Hilman
2010-12-21 1:34 ` Tony Lindgren
2010-12-09 20:58 ` Ben Dooks
2010-12-09 17:04 ` Paul Walmsley
2010-12-09 14:24 ` [PATCH v2 2/2] OMAP: serial: Change device name: omap-hsuart -> omap_uart Benoit Cousson
2010-12-09 16:56 ` [PATCH v2 0/2] OMAP: I2C and UART device name cleanup Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vzydgxr.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=b-cousson@ti.com \
--cc=ben-i2c@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox