* [PATCH]PM: Initialization of SDRC params for DVFS on Zoom2
@ 2009-10-07 8:57 Reddy, Teerth
2009-10-07 13:13 ` Kevin Hilman
0 siblings, 1 reply; 9+ messages in thread
From: Reddy, Teerth @ 2009-10-07 8:57 UTC (permalink / raw)
To: linux-omap@vger.kernel.org, Kevin Hilman
>From ba898041224fc496f6694b0ebca9afa77190abf0 Mon Sep 17 00:00:00 2001
From: Teerth Reddy <teerth@ti.com>
Date: Wed, 9 Sep 2009 10:38:30 +0530
Subject: [PATCH] ARM: OMAP3: PM: Initialize SDRC params for DVFS for Zoom2
This patch initializes the SDRC params for DVFS.
Signed-off-by: Teerth Reddy <teerth@ti.com>
---
arch/arm/mach-omap2/board-zoom2.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
Index: linux-omap-pm/arch/arm/mach-omap2/board-zoom2.c
===================================================================
--- linux-omap-pm.orig/arch/arm/mach-omap2/board-zoom2.c
+++ linux-omap-pm/arch/arm/mach-omap2/board-zoom2.c
@@ -26,6 +26,7 @@
#include "mmc-twl4030.h"
#include "omap3-opp.h"
+#include "sdram-micron-mt46h32m32lf-6.h"
/* Zoom2 has Qwerty keyboard*/
static int board_keymap[] = {
@@ -214,8 +215,9 @@ static void __init omap_zoom2_init_irq(v
{
omap_board_config = zoom2_config;
omap_board_config_size = ARRAY_SIZE(zoom2_config);
- omap2_init_common_hw(NULL, NULL, omap3_mpu_rate_table,
- omap3_dsp_rate_table, omap3_l3_rate_table);
+ omap2_init_common_hw(mt46h32m32lf6_sdrc_params,
+ mt46h32m32lf6_sdrc_params, omap3_mpu_rate_table,
+ omap3_dsp_rate_table, omap3_l3_rate_table);
omap_init_irq();
omap_gpio_init();
}
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH]PM: Initialization of SDRC params for DVFS on Zoom2
2009-10-07 8:57 [PATCH]PM: Initialization of SDRC params for DVFS on Zoom2 Reddy, Teerth
@ 2009-10-07 13:13 ` Kevin Hilman
0 siblings, 0 replies; 9+ messages in thread
From: Kevin Hilman @ 2009-10-07 13:13 UTC (permalink / raw)
To: Reddy, Teerth; +Cc: linux-omap@vger.kernel.org
"Reddy, Teerth" <teerth@ti.com> writes:
> From ba898041224fc496f6694b0ebca9afa77190abf0 Mon Sep 17 00:00:00 2001
> From: Teerth Reddy <teerth@ti.com>
> Date: Wed, 9 Sep 2009 10:38:30 +0530
> Subject: [PATCH] ARM: OMAP3: PM: Initialize SDRC params for DVFS for Zoom2
>
> This patch initializes the SDRC params for DVFS.
>
> Signed-off-by: Teerth Reddy <teerth@ti.com>
Teerth,
Please resubmit this patch against linux-omap master. This
fix could go into 2.6.32 fixes.
Kevin
> ---
> arch/arm/mach-omap2/board-zoom2.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> Index: linux-omap-pm/arch/arm/mach-omap2/board-zoom2.c
> ===================================================================
> --- linux-omap-pm.orig/arch/arm/mach-omap2/board-zoom2.c
> +++ linux-omap-pm/arch/arm/mach-omap2/board-zoom2.c
> @@ -26,6 +26,7 @@
>
> #include "mmc-twl4030.h"
> #include "omap3-opp.h"
> +#include "sdram-micron-mt46h32m32lf-6.h"
>
> /* Zoom2 has Qwerty keyboard*/
> static int board_keymap[] = {
> @@ -214,8 +215,9 @@ static void __init omap_zoom2_init_irq(v
> {
> omap_board_config = zoom2_config;
> omap_board_config_size = ARRAY_SIZE(zoom2_config);
> - omap2_init_common_hw(NULL, NULL, omap3_mpu_rate_table,
> - omap3_dsp_rate_table, omap3_l3_rate_table);
> + omap2_init_common_hw(mt46h32m32lf6_sdrc_params,
> + mt46h32m32lf6_sdrc_params, omap3_mpu_rate_table,
> + omap3_dsp_rate_table, omap3_l3_rate_table);
> omap_init_irq();
> omap_gpio_init();
> }
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH]PM: Initialization of SDRC params for DVFS on Zoom2
@ 2009-09-07 13:49 Reddy, Teerth
2009-09-08 22:17 ` Kevin Hilman
0 siblings, 1 reply; 9+ messages in thread
From: Reddy, Teerth @ 2009-09-07 13:49 UTC (permalink / raw)
To: linux-omap@vger.kernel.org, khilman@deeprootsystems.com
This patch initializes the SDRC params for DVFS on Zoom2.
Signed-off-by: Teerth Reddy <teerth@ti.com>
---
arch/arm/mach-omap2/board-zoom2.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
Index: linux-omap-pm/arch/arm/mach-omap2/board-zoom2.c
===================================================================
--- linux-omap-pm.orig/arch/arm/mach-omap2/board-zoom2.c
+++ linux-omap-pm/arch/arm/mach-omap2/board-zoom2.c
@@ -23,6 +23,7 @@
#include "mmc-twl4030.h"
#include "omap3-opp.h"
+#include "sdram-micron-mt46h32m32lf-6.h"
static struct omap_uart_config zoom2_uart_config __initdata = {
.enabled_uarts = ((1 << 0) | (1 << 1) | (1 << 2)),
@@ -36,8 +37,9 @@ static void __init omap_zoom2_init_irq(v
{
omap_board_config = zoom2_config;
omap_board_config_size = ARRAY_SIZE(zoom2_config);
- omap2_init_common_hw(NULL, NULL, omap3_mpu_rate_table,
- omap3_dsp_rate_table, omap3_l3_rate_table);
+ omap2_init_common_hw(mt46h32m32lf6_sdrc_params, NULL,
+ omap3_mpu_rate_table, omap3_dsp_rate_table,
+ omap3_l3_rate_table);
omap_init_irq();
omap_gpio_init();
}
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH]PM: Initialization of SDRC params for DVFS on Zoom2
2009-09-07 13:49 Reddy, Teerth
@ 2009-09-08 22:17 ` Kevin Hilman
2009-09-09 12:12 ` Jean Pihet
0 siblings, 1 reply; 9+ messages in thread
From: Kevin Hilman @ 2009-09-08 22:17 UTC (permalink / raw)
To: Reddy, Teerth; +Cc: linux-omap@vger.kernel.org
"Reddy, Teerth" <teerth@ti.com> writes:
> This patch initializes the SDRC params for DVFS on Zoom2.
>
> Signed-off-by: Teerth Reddy <teerth@ti.com>
> ---
> arch/arm/mach-omap2/board-zoom2.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> Index: linux-omap-pm/arch/arm/mach-omap2/board-zoom2.c
> ===================================================================
> --- linux-omap-pm.orig/arch/arm/mach-omap2/board-zoom2.c
> +++ linux-omap-pm/arch/arm/mach-omap2/board-zoom2.c
> @@ -23,6 +23,7 @@
>
> #include "mmc-twl4030.h"
> #include "omap3-opp.h"
> +#include "sdram-micron-mt46h32m32lf-6.h"
>
> static struct omap_uart_config zoom2_uart_config __initdata = {
> .enabled_uarts = ((1 << 0) | (1 << 1) | (1 << 2)),
> @@ -36,8 +37,9 @@ static void __init omap_zoom2_init_irq(v
> {
> omap_board_config = zoom2_config;
> omap_board_config_size = ARRAY_SIZE(zoom2_config);
> - omap2_init_common_hw(NULL, NULL, omap3_mpu_rate_table,
> - omap3_dsp_rate_table, omap3_l3_rate_table);
> + omap2_init_common_hw(mt46h32m32lf6_sdrc_params, NULL,
> + omap3_mpu_rate_table, omap3_dsp_rate_table,
> + omap3_l3_rate_table);
Not having looked at the Zoom2 schematics, are you sure this is only
using a single chip select? The other boards using the same part
(beagle, overo) are interfacing to this part using both CSes.
Have you tested DVFS on Zoom2 using the full 256Mb?
Kevin
> omap_init_irq();
> omap_gpio_init();
> }
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH]PM: Initialization of SDRC params for DVFS on Zoom2
2009-09-08 22:17 ` Kevin Hilman
@ 2009-09-09 12:12 ` Jean Pihet
2009-09-30 18:06 ` Kevin Hilman
0 siblings, 1 reply; 9+ messages in thread
From: Jean Pihet @ 2009-09-09 12:12 UTC (permalink / raw)
To: Kevin Hilman; +Cc: Reddy, Teerth, linux-omap@vger.kernel.org
On Wednesday 09 September 2009 00:17:42 Kevin Hilman wrote:
> "Reddy, Teerth" <teerth@ti.com> writes:
> > This patch initializes the SDRC params for DVFS on Zoom2.
> >
> > Signed-off-by: Teerth Reddy <teerth@ti.com>
> > ---
> > arch/arm/mach-omap2/board-zoom2.c | 6 ++++--
> > 1 files changed, 4 insertions(+), 2 deletions(-)
> >
> > Index: linux-omap-pm/arch/arm/mach-omap2/board-zoom2.c
> > ===================================================================
> > --- linux-omap-pm.orig/arch/arm/mach-omap2/board-zoom2.c
> > +++ linux-omap-pm/arch/arm/mach-omap2/board-zoom2.c
> > @@ -23,6 +23,7 @@
> >
> > #include "mmc-twl4030.h"
> > #include "omap3-opp.h"
> > +#include "sdram-micron-mt46h32m32lf-6.h"
> >
> > static struct omap_uart_config zoom2_uart_config __initdata = {
> > .enabled_uarts = ((1 << 0) | (1 << 1) | (1 << 2)),
> > @@ -36,8 +37,9 @@ static void __init omap_zoom2_init_irq(v
> > {
> > omap_board_config = zoom2_config;
> > omap_board_config_size = ARRAY_SIZE(zoom2_config);
> > - omap2_init_common_hw(NULL, NULL, omap3_mpu_rate_table,
> > - omap3_dsp_rate_table, omap3_l3_rate_table);
> > + omap2_init_common_hw(mt46h32m32lf6_sdrc_params, NULL,
> > + omap3_mpu_rate_table, omap3_dsp_rate_table,
> > + omap3_l3_rate_table);
>
> Not having looked at the Zoom2 schematics, are you sure this is only
> using a single chip select? The other boards using the same part
> (beagle, overo) are interfacing to this part using both CSes.
>
> Have you tested DVFS on Zoom2 using the full 256Mb?
Good point!
DVFS works fine using the two chip selects:
omap2_init_common_hw(mt46h32m32lf6_sdrc_params,
mt46h32m32lf6_sdrc_params,
omap3_mpu_rate_table,
omap3_dsp_rate_table,
omap3_l3_rate_table);
One remark though: since the memory chips are popped on top of the OMAP chip
the schematics are not showing the chip selects connections. In any case
U-Boot is configuring the SDRC module to use the 2 chip selects, so I think
this change is needed.
We need confirmation. Anyone from TI knows?
Regards,
Jean
>
> Kevin
>
> > omap_init_irq();
> > omap_gpio_init();
> > }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH]PM: Initialization of SDRC params for DVFS on Zoom2
2009-09-09 12:12 ` Jean Pihet
@ 2009-09-30 18:06 ` Kevin Hilman
2009-10-06 10:34 ` Reddy, Teerth
0 siblings, 1 reply; 9+ messages in thread
From: Kevin Hilman @ 2009-09-30 18:06 UTC (permalink / raw)
To: Reddy, Teerth; +Cc: linux-omap@vger.kernel.org, Jean Pihet
Teerth, ping.
On Wed, Sep 9, 2009 at 5:12 AM, Jean Pihet <jpihet@mvista.com> wrote:
> On Wednesday 09 September 2009 00:17:42 Kevin Hilman wrote:
>> "Reddy, Teerth" <teerth@ti.com> writes:
>> > This patch initializes the SDRC params for DVFS on Zoom2.
>> >
>> > Signed-off-by: Teerth Reddy <teerth@ti.com>
>> > ---
>> > arch/arm/mach-omap2/board-zoom2.c | 6 ++++--
>> > 1 files changed, 4 insertions(+), 2 deletions(-)
>> >
>> > Index: linux-omap-pm/arch/arm/mach-omap2/board-zoom2.c
>> > ===================================================================
>> > --- linux-omap-pm.orig/arch/arm/mach-omap2/board-zoom2.c
>> > +++ linux-omap-pm/arch/arm/mach-omap2/board-zoom2.c
>> > @@ -23,6 +23,7 @@
>> >
>> > #include "mmc-twl4030.h"
>> > #include "omap3-opp.h"
>> > +#include "sdram-micron-mt46h32m32lf-6.h"
>> >
>> > static struct omap_uart_config zoom2_uart_config __initdata = {
>> > .enabled_uarts = ((1 << 0) | (1 << 1) | (1 << 2)),
>> > @@ -36,8 +37,9 @@ static void __init omap_zoom2_init_irq(v
>> > {
>> > omap_board_config = zoom2_config;
>> > omap_board_config_size = ARRAY_SIZE(zoom2_config);
>> > - omap2_init_common_hw(NULL, NULL, omap3_mpu_rate_table,
>> > - omap3_dsp_rate_table, omap3_l3_rate_table);
>> > + omap2_init_common_hw(mt46h32m32lf6_sdrc_params, NULL,
>> > + omap3_mpu_rate_table, omap3_dsp_rate_table,
>> > + omap3_l3_rate_table);
>>
>> Not having looked at the Zoom2 schematics, are you sure this is only
>> using a single chip select? The other boards using the same part
>> (beagle, overo) are interfacing to this part using both CSes.
>>
>> Have you tested DVFS on Zoom2 using the full 256Mb?
> Good point!
>
> DVFS works fine using the two chip selects:
> omap2_init_common_hw(mt46h32m32lf6_sdrc_params,
> mt46h32m32lf6_sdrc_params,
> omap3_mpu_rate_table,
> omap3_dsp_rate_table,
> omap3_l3_rate_table);
>
> One remark though: since the memory chips are popped on top of the OMAP chip
> the schematics are not showing the chip selects connections. In any case
> U-Boot is configuring the SDRC module to use the 2 chip selects, so I think
> this change is needed.
>
> We need confirmation. Anyone from TI knows?
>
> Regards,
> Jean
>
>>
>> Kevin
>>
>> > omap_init_irq();
>> > omap_gpio_init();
>> > }
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [PATCH]PM: Initialization of SDRC params for DVFS on Zoom2
2009-09-30 18:06 ` Kevin Hilman
@ 2009-10-06 10:34 ` Reddy, Teerth
2009-10-06 13:19 ` Kevin Hilman
2009-10-06 13:32 ` Kevin Hilman
0 siblings, 2 replies; 9+ messages in thread
From: Reddy, Teerth @ 2009-10-06 10:34 UTC (permalink / raw)
To: Kevin Hilman; +Cc: linux-omap@vger.kernel.org, Jean Pihet
Kevin,Jean
Sorry for the late reply.
I have tested DVFS on Zoom2 with 256Mb with this patch and it works fine.
In Zoom2 SDRC module uses 2 chip selects. Since u-boot is configuring the SDRC module to use 2 chip selects do we need to configure it in the kernel as well?
If you think so then this change is needed.
Regards
Teerth
-----Original Message-----
From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
Sent: Wednesday, September 30, 2009 11:36 PM
To: Reddy, Teerth
Cc: linux-omap@vger.kernel.org; Jean Pihet
Subject: Re: [PATCH]PM: Initialization of SDRC params for DVFS on Zoom2
Teerth, ping.
On Wed, Sep 9, 2009 at 5:12 AM, Jean Pihet <jpihet@mvista.com> wrote:
> On Wednesday 09 September 2009 00:17:42 Kevin Hilman wrote:
>> "Reddy, Teerth" <teerth@ti.com> writes:
>> > This patch initializes the SDRC params for DVFS on Zoom2.
>> >
>> > Signed-off-by: Teerth Reddy <teerth@ti.com>
>> > ---
>> > arch/arm/mach-omap2/board-zoom2.c | 6 ++++--
>> > 1 files changed, 4 insertions(+), 2 deletions(-)
>> >
>> > Index: linux-omap-pm/arch/arm/mach-omap2/board-zoom2.c
>> > ===================================================================
>> > --- linux-omap-pm.orig/arch/arm/mach-omap2/board-zoom2.c
>> > +++ linux-omap-pm/arch/arm/mach-omap2/board-zoom2.c
>> > @@ -23,6 +23,7 @@
>> >
>> > #include "mmc-twl4030.h"
>> > #include "omap3-opp.h"
>> > +#include "sdram-micron-mt46h32m32lf-6.h"
>> >
>> > static struct omap_uart_config zoom2_uart_config __initdata = {
>> > .enabled_uarts = ((1 << 0) | (1 << 1) | (1 << 2)),
>> > @@ -36,8 +37,9 @@ static void __init omap_zoom2_init_irq(v
>> > {
>> > omap_board_config = zoom2_config;
>> > omap_board_config_size = ARRAY_SIZE(zoom2_config);
>> > - omap2_init_common_hw(NULL, NULL, omap3_mpu_rate_table,
>> > - omap3_dsp_rate_table, omap3_l3_rate_table);
>> > + omap2_init_common_hw(mt46h32m32lf6_sdrc_params, NULL,
>> > + omap3_mpu_rate_table, omap3_dsp_rate_table,
>> > + omap3_l3_rate_table);
>>
>> Not having looked at the Zoom2 schematics, are you sure this is only
>> using a single chip select? The other boards using the same part
>> (beagle, overo) are interfacing to this part using both CSes.
>>
>> Have you tested DVFS on Zoom2 using the full 256Mb?
> Good point!
>
> DVFS works fine using the two chip selects:
> omap2_init_common_hw(mt46h32m32lf6_sdrc_params,
> mt46h32m32lf6_sdrc_params,
> omap3_mpu_rate_table,
> omap3_dsp_rate_table,
> omap3_l3_rate_table);
>
> One remark though: since the memory chips are popped on top of the OMAP chip
> the schematics are not showing the chip selects connections. In any case
> U-Boot is configuring the SDRC module to use the 2 chip selects, so I think
> this change is needed.
>
> We need confirmation. Anyone from TI knows?
>
> Regards,
> Jean
>
>>
>> Kevin
>>
>> > omap_init_irq();
>> > omap_gpio_init();
>> > }
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH]PM: Initialization of SDRC params for DVFS on Zoom2
2009-10-06 10:34 ` Reddy, Teerth
@ 2009-10-06 13:19 ` Kevin Hilman
2009-10-06 13:32 ` Kevin Hilman
1 sibling, 0 replies; 9+ messages in thread
From: Kevin Hilman @ 2009-10-06 13:19 UTC (permalink / raw)
To: Reddy, Teerth; +Cc: linux-omap@vger.kernel.org, Jean Pihet
"Reddy, Teerth" <teerth@ti.com> writes:
> Kevin,Jean
>
> Sorry for the late reply.
> I have tested DVFS on Zoom2 with 256Mb with this patch and it works fine.
> In Zoom2 SDRC module uses 2 chip selects. Since u-boot is configuring the SDRC module to use 2 chip selects do we need to configure it in the kernel as well?
> If you think so then this change is needed.
Yes, otherwise the settings for the 2nd CS will not be modified during
DVFS and DVFS will not work properly when using both CSes.
Kevin
>
> Regards
> Teerth
>
>
>
> -----Original Message-----
> From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
> Sent: Wednesday, September 30, 2009 11:36 PM
> To: Reddy, Teerth
> Cc: linux-omap@vger.kernel.org; Jean Pihet
> Subject: Re: [PATCH]PM: Initialization of SDRC params for DVFS on Zoom2
>
> Teerth, ping.
>
> On Wed, Sep 9, 2009 at 5:12 AM, Jean Pihet <jpihet@mvista.com> wrote:
>> On Wednesday 09 September 2009 00:17:42 Kevin Hilman wrote:
>>> "Reddy, Teerth" <teerth@ti.com> writes:
>>> > This patch initializes the SDRC params for DVFS on Zoom2.
>>> >
>>> > Signed-off-by: Teerth Reddy <teerth@ti.com>
>>> > ---
>>> > arch/arm/mach-omap2/board-zoom2.c | 6 ++++--
>>> > 1 files changed, 4 insertions(+), 2 deletions(-)
>>> >
>>> > Index: linux-omap-pm/arch/arm/mach-omap2/board-zoom2.c
>>> > ===================================================================
>>> > --- linux-omap-pm.orig/arch/arm/mach-omap2/board-zoom2.c
>>> > +++ linux-omap-pm/arch/arm/mach-omap2/board-zoom2.c
>>> > @@ -23,6 +23,7 @@
>>> >
>>> > #include "mmc-twl4030.h"
>>> > #include "omap3-opp.h"
>>> > +#include "sdram-micron-mt46h32m32lf-6.h"
>>> >
>>> > static struct omap_uart_config zoom2_uart_config __initdata = {
>>> > .enabled_uarts = ((1 << 0) | (1 << 1) | (1 << 2)),
>>> > @@ -36,8 +37,9 @@ static void __init omap_zoom2_init_irq(v
>>> > {
>>> > omap_board_config = zoom2_config;
>>> > omap_board_config_size = ARRAY_SIZE(zoom2_config);
>>> > - omap2_init_common_hw(NULL, NULL, omap3_mpu_rate_table,
>>> > - omap3_dsp_rate_table, omap3_l3_rate_table);
>>> > + omap2_init_common_hw(mt46h32m32lf6_sdrc_params, NULL,
>>> > + omap3_mpu_rate_table, omap3_dsp_rate_table,
>>> > + omap3_l3_rate_table);
>>>
>>> Not having looked at the Zoom2 schematics, are you sure this is only
>>> using a single chip select? The other boards using the same part
>>> (beagle, overo) are interfacing to this part using both CSes.
>>>
>>> Have you tested DVFS on Zoom2 using the full 256Mb?
>> Good point!
>>
>> DVFS works fine using the two chip selects:
>> omap2_init_common_hw(mt46h32m32lf6_sdrc_params,
>> mt46h32m32lf6_sdrc_params,
>> omap3_mpu_rate_table,
>> omap3_dsp_rate_table,
>> omap3_l3_rate_table);
>>
>> One remark though: since the memory chips are popped on top of the OMAP chip
>> the schematics are not showing the chip selects connections. In any case
>> U-Boot is configuring the SDRC module to use the 2 chip selects, so I think
>> this change is needed.
>>
>> We need confirmation. Anyone from TI knows?
>>
>> Regards,
>> Jean
>>
>>>
>>> Kevin
>>>
>>> > omap_init_irq();
>>> > omap_gpio_init();
>>> > }
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH]PM: Initialization of SDRC params for DVFS on Zoom2
2009-10-06 10:34 ` Reddy, Teerth
2009-10-06 13:19 ` Kevin Hilman
@ 2009-10-06 13:32 ` Kevin Hilman
1 sibling, 0 replies; 9+ messages in thread
From: Kevin Hilman @ 2009-10-06 13:32 UTC (permalink / raw)
To: Reddy, Teerth; +Cc: linux-omap@vger.kernel.org, Jean Pihet
"Reddy, Teerth" <teerth@ti.com> writes:
> Kevin,Jean
>
> Sorry for the late reply.
> I have tested DVFS on Zoom2 with 256Mb with this patch and it works fine.
> In Zoom2 SDRC module uses 2 chip selects. Since u-boot is configuring the SDRC module to use 2 chip selects do we need to configure it in the kernel as well?
> If you think so then this change is needed.
Teerth,
Please break this up into two patches.
1) for linux-omap master: add the SDRC params for both CSes to init_common_hw
2) for PM branch: addition of rate tables for DVFS
Thanks,
> Regards
> Teerth
>
>
>
> -----Original Message-----
> From: Kevin Hilman [mailto:khilman@deeprootsystems.com]
> Sent: Wednesday, September 30, 2009 11:36 PM
> To: Reddy, Teerth
> Cc: linux-omap@vger.kernel.org; Jean Pihet
> Subject: Re: [PATCH]PM: Initialization of SDRC params for DVFS on Zoom2
>
> Teerth, ping.
>
> On Wed, Sep 9, 2009 at 5:12 AM, Jean Pihet <jpihet@mvista.com> wrote:
>> On Wednesday 09 September 2009 00:17:42 Kevin Hilman wrote:
>>> "Reddy, Teerth" <teerth@ti.com> writes:
>>> > This patch initializes the SDRC params for DVFS on Zoom2.
>>> >
>>> > Signed-off-by: Teerth Reddy <teerth@ti.com>
>>> > ---
>>> > arch/arm/mach-omap2/board-zoom2.c | 6 ++++--
>>> > 1 files changed, 4 insertions(+), 2 deletions(-)
>>> >
>>> > Index: linux-omap-pm/arch/arm/mach-omap2/board-zoom2.c
>>> > ===================================================================
>>> > --- linux-omap-pm.orig/arch/arm/mach-omap2/board-zoom2.c
>>> > +++ linux-omap-pm/arch/arm/mach-omap2/board-zoom2.c
>>> > @@ -23,6 +23,7 @@
>>> >
>>> > #include "mmc-twl4030.h"
>>> > #include "omap3-opp.h"
>>> > +#include "sdram-micron-mt46h32m32lf-6.h"
>>> >
>>> > static struct omap_uart_config zoom2_uart_config __initdata = {
>>> > .enabled_uarts = ((1 << 0) | (1 << 1) | (1 << 2)),
>>> > @@ -36,8 +37,9 @@ static void __init omap_zoom2_init_irq(v
>>> > {
>>> > omap_board_config = zoom2_config;
>>> > omap_board_config_size = ARRAY_SIZE(zoom2_config);
>>> > - omap2_init_common_hw(NULL, NULL, omap3_mpu_rate_table,
>>> > - omap3_dsp_rate_table, omap3_l3_rate_table);
>>> > + omap2_init_common_hw(mt46h32m32lf6_sdrc_params, NULL,
>>> > + omap3_mpu_rate_table, omap3_dsp_rate_table,
>>> > + omap3_l3_rate_table);
>>>
>>> Not having looked at the Zoom2 schematics, are you sure this is only
>>> using a single chip select? The other boards using the same part
>>> (beagle, overo) are interfacing to this part using both CSes.
>>>
>>> Have you tested DVFS on Zoom2 using the full 256Mb?
>> Good point!
>>
>> DVFS works fine using the two chip selects:
>> omap2_init_common_hw(mt46h32m32lf6_sdrc_params,
>> mt46h32m32lf6_sdrc_params,
>> omap3_mpu_rate_table,
>> omap3_dsp_rate_table,
>> omap3_l3_rate_table);
>>
>> One remark though: since the memory chips are popped on top of the OMAP chip
>> the schematics are not showing the chip selects connections. In any case
>> U-Boot is configuring the SDRC module to use the 2 chip selects, so I think
>> this change is needed.
>>
>> We need confirmation. Anyone from TI knows?
>>
>> Regards,
>> Jean
>>
>>>
>>> Kevin
>>>
>>> > omap_init_irq();
>>> > omap_gpio_init();
>>> > }
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2009-10-07 13:13 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-07 8:57 [PATCH]PM: Initialization of SDRC params for DVFS on Zoom2 Reddy, Teerth
2009-10-07 13:13 ` Kevin Hilman
-- strict thread matches above, loose matches on Subject: below --
2009-09-07 13:49 Reddy, Teerth
2009-09-08 22:17 ` Kevin Hilman
2009-09-09 12:12 ` Jean Pihet
2009-09-30 18:06 ` Kevin Hilman
2009-10-06 10:34 ` Reddy, Teerth
2009-10-06 13:19 ` Kevin Hilman
2009-10-06 13:32 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox