From: Kevin Hilman <khilman@deeprootsystems.com>
To: Aaro Koskinen <Aaro.Koskinen@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PM PATCH] OMAP3: PM: Fix INTC context save/restore
Date: Thu, 12 Mar 2009 09:33:59 -0700 [thread overview]
Message-ID: <878wna8zuw.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1236874349-31261-1-git-send-email-Aaro.Koskinen@nokia.com> (Aaro Koskinen's message of "Thu\, 12 Mar 2009 18\:12\:29 +0200")
Aaro Koskinen <Aaro.Koskinen@nokia.com> writes:
> Wrong index was used for ILR.
>
> Signed-off-by: Aaro Koskinen <Aaro.Koskinen@nokia.com>
Thanks, pushed to PM brach.
Kevin
> ---
> arch/arm/mach-omap2/irq.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c
> index 6cc5757..f813916 100644
> --- a/arch/arm/mach-omap2/irq.c
> +++ b/arch/arm/mach-omap2/irq.c
> @@ -244,7 +244,7 @@ void omap3_intc_save_context(void)
> intc_bank_read_reg(bank, INTC_THRESHOLD);
> for (i = 0; i < INTCPS_NR_IRQS; i++)
> intc_context[ind].ilr[i] =
> - intc_bank_read_reg(bank, (0x100 + 0x4*ind));
> + intc_bank_read_reg(bank, (0x100 + 0x4*i));
> for (i = 0; i < INTCPS_NR_MIR_REGS; i++)
> intc_context[ind].mir[i] =
> intc_bank_read_reg(&irq_banks[0], INTC_MIR0 +
> @@ -270,7 +270,7 @@ void omap3_intc_restore_context(void)
> bank, INTC_THRESHOLD);
> for (i = 0; i < INTCPS_NR_IRQS; i++)
> intc_bank_write_reg(intc_context[ind].ilr[i],
> - bank, (0x100 + 0x4*ind));
> + bank, (0x100 + 0x4*i));
> for (i = 0; i < INTCPS_NR_MIR_REGS; i++)
> intc_bank_write_reg(intc_context[ind].mir[i],
> &irq_banks[0], INTC_MIR0 + (0x20 * i));
> --
> 1.5.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-03-12 16:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 16:12 [PM PATCH] OMAP3: PM: Fix INTC context save/restore Aaro Koskinen
2009-03-12 16:33 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878wna8zuw.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=Aaro.Koskinen@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox