* [PM PATCH] OMAP3: PM: Fix INTC context save/restore
@ 2009-03-12 16:12 Aaro Koskinen
2009-03-12 16:33 ` Kevin Hilman
0 siblings, 1 reply; 2+ messages in thread
From: Aaro Koskinen @ 2009-03-12 16:12 UTC (permalink / raw)
To: linux-omap
Wrong index was used for ILR.
Signed-off-by: Aaro Koskinen <Aaro.Koskinen@nokia.com>
---
arch/arm/mach-omap2/irq.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c
index 6cc5757..f813916 100644
--- a/arch/arm/mach-omap2/irq.c
+++ b/arch/arm/mach-omap2/irq.c
@@ -244,7 +244,7 @@ void omap3_intc_save_context(void)
intc_bank_read_reg(bank, INTC_THRESHOLD);
for (i = 0; i < INTCPS_NR_IRQS; i++)
intc_context[ind].ilr[i] =
- intc_bank_read_reg(bank, (0x100 + 0x4*ind));
+ intc_bank_read_reg(bank, (0x100 + 0x4*i));
for (i = 0; i < INTCPS_NR_MIR_REGS; i++)
intc_context[ind].mir[i] =
intc_bank_read_reg(&irq_banks[0], INTC_MIR0 +
@@ -270,7 +270,7 @@ void omap3_intc_restore_context(void)
bank, INTC_THRESHOLD);
for (i = 0; i < INTCPS_NR_IRQS; i++)
intc_bank_write_reg(intc_context[ind].ilr[i],
- bank, (0x100 + 0x4*ind));
+ bank, (0x100 + 0x4*i));
for (i = 0; i < INTCPS_NR_MIR_REGS; i++)
intc_bank_write_reg(intc_context[ind].mir[i],
&irq_banks[0], INTC_MIR0 + (0x20 * i));
--
1.5.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PM PATCH] OMAP3: PM: Fix INTC context save/restore
2009-03-12 16:12 [PM PATCH] OMAP3: PM: Fix INTC context save/restore Aaro Koskinen
@ 2009-03-12 16:33 ` Kevin Hilman
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Hilman @ 2009-03-12 16:33 UTC (permalink / raw)
To: Aaro Koskinen; +Cc: linux-omap
Aaro Koskinen <Aaro.Koskinen@nokia.com> writes:
> Wrong index was used for ILR.
>
> Signed-off-by: Aaro Koskinen <Aaro.Koskinen@nokia.com>
Thanks, pushed to PM brach.
Kevin
> ---
> arch/arm/mach-omap2/irq.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c
> index 6cc5757..f813916 100644
> --- a/arch/arm/mach-omap2/irq.c
> +++ b/arch/arm/mach-omap2/irq.c
> @@ -244,7 +244,7 @@ void omap3_intc_save_context(void)
> intc_bank_read_reg(bank, INTC_THRESHOLD);
> for (i = 0; i < INTCPS_NR_IRQS; i++)
> intc_context[ind].ilr[i] =
> - intc_bank_read_reg(bank, (0x100 + 0x4*ind));
> + intc_bank_read_reg(bank, (0x100 + 0x4*i));
> for (i = 0; i < INTCPS_NR_MIR_REGS; i++)
> intc_context[ind].mir[i] =
> intc_bank_read_reg(&irq_banks[0], INTC_MIR0 +
> @@ -270,7 +270,7 @@ void omap3_intc_restore_context(void)
> bank, INTC_THRESHOLD);
> for (i = 0; i < INTCPS_NR_IRQS; i++)
> intc_bank_write_reg(intc_context[ind].ilr[i],
> - bank, (0x100 + 0x4*ind));
> + bank, (0x100 + 0x4*i));
> for (i = 0; i < INTCPS_NR_MIR_REGS; i++)
> intc_bank_write_reg(intc_context[ind].mir[i],
> &irq_banks[0], INTC_MIR0 + (0x20 * i));
> --
> 1.5.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-12 16:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-12 16:12 [PM PATCH] OMAP3: PM: Fix INTC context save/restore Aaro Koskinen
2009-03-12 16:33 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox